getModule/getReactModuleInfoProvider required for TurboModules?

[lindboe]

I noticed in the "Migration to the New Architecture" > "Supporting in your Library" > "Enabling in Android Library" section, there's no mention of the methods that are added to the ModulePackage class in the guide to creating a new Turbo Module.

The relevant example code:

- override fun getModule(name: String?, reactContext: ReactApplicationContext): NativeModule? = null
+ override fun getModule(name: String?, reactContext: ReactApplicationContext): NativeModule? =
+   if (name == CalculatorModule.NAME) {
+     CalculatorModule(reactContext)
+   } else {
+     null
+   }

- override fun getReactModuleInfoProvider() = ReactModuleInfoProvider? = null
+ override fun getReactModuleInfoProvider() = ReactModuleInfoProvider {
+   mapOf(
+     CalculatorModule.NAME to ReactModuleInfo(
+       CalculatorModule.NAME,
+       CalculatorModule.NAME,
+       false, // canOverrideExistingModule
+       false, // needsEagerInit
+       true, // hasConstants
+       false, // isCxxModule
+       true // isTurboModule
+     )
+   )
+ }
}

Is this step required to migrate to the New Architecture? If so, I think these docs should cover that and how to manage the existing Package class code (which I understand would be migrating away from using createNativeModules/createViewManagers, correct?)

[cortinico]

Hi @lindboe
That's correct. The *Package class should also be updated to extend from TurboReactPackage.
Would you be up for sending a PR against the "Enabling in Android Library" page to include a paragraph about it?

[lindboe]

Yup, I can do that, just wanted to make sure that's correct. Thanks!