Merge pull request #95 from clue-labs/internal

Mark internal API as private to discourage inheritance

Author: WyriHaximus

src/DuplexResourceStream.php

@@ -8,6 +8,9 @@
 
 class DuplexResourceStream extends EventEmitter implements DuplexStreamInterface
 {
+    private $stream;
+    private $loop;
+
     /**
      * Controls the maximum buffer size in bytes to read at once from the stream.
      *
@@ -25,13 +28,11 @@ class DuplexResourceStream extends EventEmitter implements DuplexStreamInterface
      * @var int
      */
     private $bufferSize;
+    private $buffer;
 
-    private $stream;
-    protected $readable = true;
-    protected $writable = true;
-    protected $closing = false;
-    protected $loop;
-    protected $buffer;
+    private $readable = true;
+    private $writable = true;
+    private $closing = false;
 
     public function __construct($stream, LoopInterface $loop, $readChunkSize = null, WritableStreamInterface $buffer = null)
     {
@@ -157,6 +158,7 @@ public function pipe(WritableStreamInterface $dest, array $options = array())
         return Util::pipe($this, $dest, $options);
     }
 
+    /** @internal */
     public function handleData($stream)
     {
         $error = null;
@@ -189,6 +191,7 @@ public function handleData($stream)
         }
     }
 
+    /** @internal */
     public function handleClose()
     {
         if (is_resource($this->stream)) {

src/ReadableResourceStream.php

@@ -8,6 +8,13 @@
 
 class ReadableResourceStream extends EventEmitter implements ReadableStreamInterface
 {
+    /**
+     * @var resource
+     */
+    private $stream;
+
+    private $loop;
+
     /**
      * Controls the maximum buffer size in bytes to read at once from the stream.
      *
@@ -28,13 +35,7 @@ class ReadableResourceStream extends EventEmitter implements ReadableStreamInter
      */
     private $bufferSize;
 
-    /**
-     * @var resource
-     */
-    private $stream;
-
     private $closed = false;
-    private $loop;
 
     public function __construct($stream, LoopInterface $loop, $readChunkSize = null)
     {