Skip to content

Connection is a server side incoming connection #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2014
Merged

Connection is a server side incoming connection #13

merged 1 commit into from
Dec 4, 2014

Conversation

clue
Copy link
Member

@clue clue commented Nov 15, 2014

It MUST NOT be used in a client side context.

This has caused several issues already, so we should update our documentation accordingly.

The React\Socket namespace is part of the react/socket package which is a "Library for building an evented socket server". Hence the React\Socket\Connection should be used for an incoming connection and not for an outgoing one.

Refs #4, reactphp/stream#11 and reactphp/dns#11.

@clue
Connection is a server side incoming connection
b6d821a 
It MUST NOT be used in a client side context
@clue clue mentioned this pull request Nov 15, 2014
Closed
@clue clue mentioned this pull request Dec 3, 2014
Closed
cboden added a commit that referenced this pull request Dec 4, 2014
@cboden
Merge pull request #13 from clue-labs/patch-1
2949cf3 
Connection is a server side incoming connection
@cboden cboden merged commit 2949cf3 into reactphp:master Dec 4, 2014
@clue clue deleted the patch-1 branch December 4, 2014 14:49
@cboden cboden modified the milestone: v0.4.3 Mar 1, 2016
@clue clue mentioned this pull request Jan 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@clue @cboden