Simplify connection close logic after sending response#317
Merged
WyriHaximus merged 2 commits intoreactphp:masterfrom Apr 7, 2018
Merged
Simplify connection close logic after sending response#317WyriHaximus merged 2 commits intoreactphp:masterfrom
WyriHaximus merged 2 commits intoreactphp:masterfrom
Conversation
jsor
approved these changes
Apr 7, 2018
WyriHaximus
approved these changes
Apr 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple PR only re-arranges some code to simplify connection close logic. This does not have any effect on any of the tests (it has a small, but positive impact on benchmarking performance). This is done in preparation for #39, so expect some follow-up PRs soon-ish