Discourage libevent on PHP 7

reactphp · Oct 13, 2017 · bda850f · bda850f
1 parent ed4b051
commit bda850f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/Factory.php b/src/Factory.php
@@ -7,12 +7,13 @@ class Factory
     public static function create()
     {
         // @codeCoverageIgnoreStart
-        if (function_exists('event_base_new')) {
-            return new LibEventLoop();
-        } elseif (class_exists('libev\EventLoop', false)) {
+        if (class_exists('libev\EventLoop', false)) {
             return new LibEvLoop;
         } elseif (class_exists('EventBase', false)) {
             return new ExtEventLoop;
+        } elseif (function_exists('event_base_new') && PHP_VERSION_ID < 70000) {
+            // only use ext-libevent on PHP < 7 for now
+            return new LibEventLoop();
         }
 
         return new StreamSelectLoop();

diff --git a/src/LibEventLoop.php b/src/LibEventLoop.php
@@ -29,6 +29,10 @@ class LibEventLoop implements LoopInterface
 
     public function __construct()
     {
+        if (version_compare(PHP_VERSION, '7.0.0') >= 0) {
+            trigger_error('The libevent extension has not yet been updated for PHP 7, it is recommended you use a different loop', E_USER_WARNING);
+        }
+
         $this->eventBase = event_base_new();
         $this->futureTickQueue = new FutureTickQueue();
         $this->timerEvents = new SplObjectStorage();