Run tests on PHPUnit 9 and update PHPUnit configuration schema for PHPUnit 9.3#37
Merged
jsor merged 2 commits intoreactphp:masterfrom Jan 26, 2021
Merged
Run tests on PHPUnit 9 and update PHPUnit configuration schema for PHPUnit 9.3#37jsor merged 2 commits intoreactphp:masterfrom
jsor merged 2 commits intoreactphp:masterfrom
Conversation
WyriHaximus
approved these changes
Jan 25, 2021
clue
approved these changes
Jan 26, 2021
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
As soon as this one and reactphp/reactphp#442 is merged, I'll build on top of this and migrate this repository to GitHub Actions with full PHP 8 support 👍
jsor
approved these changes
Jan 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit 9.3 released a new schema for the
phpunit.xmlconfiguration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use thephpunit.xml.legacyconfiguration file, because the new format is unknown for them.For further details concerning this pull request look into graphp/graphviz #46.