Merge pull request #115 from 6b7562617765726c6f73/php85

[0.7.x] Improve PHP 8.5+ support by replacing binary cast with string cast

Author: WyriHaximus

.github/workflows/ci.yml

@@ -14,6 +14,7 @@ jobs:
           - ubuntu-24.04
           - windows-2022
         php:
+          - 8.5
           - 8.4
           - 8.3
           - 8.2

src/Process.php

@@ -121,7 +121,7 @@ public function __construct($cmd, $cwd = null, $env = null, $fds = null)
         if (null !== $env) {
             $this->env = array();
             foreach ($env as $key => $value) {
-                $this->env[(binary) $key] = (binary) $value;
+                $this->env[(string) $key] = (string) $value;
             }
         }
 

tests/AbstractProcessTest.php

@@ -70,7 +70,9 @@ public function testStartWithoutLoopAssignsLoopAutomatically()
         $process->start();
 
         $ref = new \ReflectionProperty($process->stdin, 'loop');
-        $ref->setAccessible(true);
+        if (PHP_VERSION_ID < 80100) {
+            $ref->setAccessible(true);
+        }
         $loop = $ref->getValue($process->stdin);
 
         $this->assertInstanceOf('React\EventLoop\LoopInterface', $loop);
@@ -515,7 +517,7 @@ public function testProcessWithDefaultCwdAndEnv()
          * environment variable (i.e. current shell/script) on some platforms.
          */
         $this->assertSame(getcwd(), $cwd);
-        $this->assertLessThanOrEqual(1, (count($_SERVER) - (integer) $envCount));
+        $this->assertLessThanOrEqual(1, (count($_SERVER) - (int) $envCount));
     }
 
     public function testProcessWithCwd()