[build] Backport last relevant build changes from 3.3 #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - using local buildSrc plugins rather than adhoc code blocks (detecting ci, java conventions, custom version) - splitting out javadoc/asciidoc gradle files - fixing the directory into which asciidocs are built - avoid building pdf reference guide locally (unless release) - remove spring-io-plugin / platform - bump asciidoctor.convert plugin - micrometer version defined in gradle.properties and pinned - reactiveStream version defined in gradle.properties - junit, awaitility, jol and testNg versions defined in properties rather than inline - use gradle enterprise plugin for buildScan - removed hamcrest-library dependency - automatic module names
simonbasle
added
the
type/chores
simonbasle
added a commit
that referenced
this pull request
May 14, 2020
Also use one testCompile instruction per line. Reviewed-in: #2156
simonbasle
force-pushed
the
alignCaliforniumBuild
branch
from
a8ce716 to
2bd0738
Compare
simonbasle
commented
May 14, 2020
reactor-test/build.gradle
Outdated
| @@ -5,7 +5,7 @@ | |||
| * you may not use this file except in compliance with the License. | |||
| * You may obtain a copy of the License at | |||
| * | |||
| * https://www.apache.org/licenses/LICENSE-2.0 | |||
| * https://www.apache.org/licenses/LICENSE-2.0 | |||
There was a problem hiding this comment.
I'll fix that, spaces are used in the license template
simonbasle
force-pushed
the
alignCaliforniumBuild
branch
from
2bd0738 to
2f24bca
Compare
bsideup
reviewed
May 14, 2020
bsideup
approved these changes
May 14, 2020
Codecov Report
@@ Coverage Diff @@
## 3.2.x #2156 +/- ##
============================================
+ Coverage 84.87% 84.91% +0.04%
- Complexity 4012 4014 +2
============================================
Files 364 364
Lines 30475 30475
Branches 5663 5663
============================================
+ Hits 25865 25879 +14
+ Misses 3010 2996 -14
Partials 1600 1600 Continue to review full report at Codecov.
|
simonbasle
changed the title
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
simonbasle
added a commit
that referenced
this pull request
May 14, 2020
Also use one testCompile instruction per line. Reviewed-in: #2156
simonbasle
added a commit
that referenced
this pull request
May 14, 2020
simonbasle
added a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
ci, java conventions, custom version)
rather than inline