Add "VirtualTimeScheduler#getScheduledTaskCount()" #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
reviewed
Jun 21, 2019
| assertThat(vts.getScheduledTaskCount()).as("a task scheduled").isEqualTo(1); | ||
|
|
||
| // schedule with delay | ||
| vts = VirtualTimeScheduler.create(); |
There was a problem hiding this comment.
I would suggest splitting it into a few different tests
bsideup
reviewed
Jun 21, 2019
Expose "counter" as scheduled task count in VirtualTimeScheduler.
|
updated the PR. |
smaldini
approved these changes
Jun 24, 2019
bsideup
approved these changes
Jun 24, 2019
|
@ttddyy thanks for your contribution! 🎉 |
simonbasle
pushed a commit
that referenced
this pull request
Nov 22, 2019
Since VirtualTimeScheduler already has "counter" that keeps track of the number of the scheduled tasks, it can be used to check whether tasks have executed on the scheduler. This change exposes that counter as "scheduled task count". (cherry picked from commit e532799) (backported for the benefit of #1916 backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose "counter" as scheduled task count in VirtualTimeScheduler.
While testing publisher logic that have
publishOn/subscribeOn, I'd like to have a way to check provided scheduler has performed the execution.Since
VirtualTimeScheduleralready havecounterthat keeps track of the number of the scheduled tasks, it can be used to check whether tasks have executed on the scheduler.For example,