Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testNG tests and reactivate task #990

Closed
simonbasle opened this issue Dec 18, 2017 · 0 comments
Closed

fix testNG tests and reactivate task #990

simonbasle opened this issue Dec 18, 2017 · 0 comments
Assignees
Labels
type/bug A general bug type/chores A task not related to code (build, formatting, process, ...)
Milestone

Comments

@simonbasle
Copy link
Member

The testNG task currently excludes all files, resulting in NO-SOURCE for the task.
If the exclude is removed and we add an includes.clear(), the correct source set is used for testNG tests, but then some tests fail on CI (see this Travis CI build).

Additional tests from `testNG` ([**/*Verification.*])


Gradle suite > Gradle test > reactor.core.publisher.tck.FluxWithProcessorVerification.mustImmediatelyPassOnOnErrorEventsReceivedFromItsUpstreamToItsDownstream FAILED

    java.lang.AssertionError


Gradle suite > Gradle test > reactor.core.publisher.tck.FluxWithProcessorVerification.required_spec209_mustBePreparedToReceiveAnOnCompleteSignalWithPrecedingRequestCall FAILED

    java.lang.AssertionError


Gradle suite > Gradle test > reactor.core.publisher.tck.FluxWithProcessorVerification.required_spec209_mustBePreparedToReceiveAnOnCompleteSignalWithoutPrecedingRequestCall FAILED

    java.lang.AssertionError


Gradle suite > Gradle test > reactor.core.publisher.tck.FluxWithProcessorVerification.required_spec210_mustBePreparedToReceiveAnOnErrorSignalWithPrecedingRequestCall FAILED

    java.lang.AssertionError


Gradle suite > Gradle test > reactor.core.publisher.tck.FluxWithProcessorVerification.required_spec210_mustBePreparedToReceiveAnOnErrorSignalWithoutPrecedingRequestCall FAILED

    java.lang.AssertionError


348 tests completed, 5 failed, 107 skipped

:reactor-core:testNG FAILED


FAILURE: Build failed with an exception.


* What went wrong:

Execution failed for task ':reactor-core:testNG'.

> There were failing tests. See the report at: file:///home/travis/build/reactor/reactor-core/reactor-core/build/reports/tests/testNG/index.html
@simonbasle simonbasle added the type/chores A task not related to code (build, formatting, process, ...) label Dec 18, 2017
@smaldini smaldini added the type/bug A general bug label Dec 18, 2017
@simonbasle simonbasle added this to the 3.1.3.RELEASE milestone Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug type/chores A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

No branches or pull requests

2 participants