Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure docsZip defines a -docs classifier #1975

Closed
simonbasle opened this issue Nov 26, 2019 · 1 comment
Closed

Ensure docsZip defines a -docs classifier #1975

simonbasle opened this issue Nov 26, 2019 · 1 comment
Labels
type/bug A general bug type/chores A task not related to code (build, formatting, process, ...) warn/regression A regression from a previous release
Milestone
3.2.14.RELEASE

Comments

@simonbasle
Copy link
Member

since switching to maven-publish, maven naming conventions are enforced. this was missed as no warning is emitted by Gradle in case the archive's name doesn't follow said conventions (the plugin transparently renames 😢).

this impacts the zip of reference documentation, which ends up following the format reactor-core-VERSION.zip instead of (formerly) reactor-core-docs-VERSION.zip. Since there is no apparent way of keeping the name, the next best thing is to use a classifier and turn the filename into a deployable reactor-core-VERSION-docs.zip. Such a zip would still only be distributed to Artifactory.

3.2.13.RELEASE and 3.3.1.RELEASE where impacted, but the zip was renamed directly on artifactory. see also reactor/projectreactor.io#48
@simonbasle simonbasle added type/bug A general bug type/chores A task not related to code (build, formatting, process, ...) warn/regression A regression from a previous release labels Nov 26, 2019
@simonbasle simonbasle added this to the 3.2.14.RELEASE milestone Nov 26, 2019
@simonbasle
Copy link
Member Author

steps:

  1. set the baseName from docsZip to reactor-core (will be renamed to the project name whose publication it is attached to anyway)
  2. add a `archiveClassifier.set('-docs')

simonbasle added a commit that referenced this issue Nov 26, 2019
@simonbasle
fix #1975 Publish docsZip with -docs classifier
84e9ba4
simonbasle added a commit that referenced this issue Nov 27, 2019
@simonbasle
Merge #1975 into 3.3
5ee0940 
 - propdeps was already reapplied in build.gradle on master, but
 propdeps-maven was not suppressed in setup.gradle
 - asciidoc.gradle changes to the target directory structure conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug A general bug type/chores A task not related to code (build, formatting, process, ...) warn/regression A regression from a previous release
Projects
None yet
Milestone
3.2.14.RELEASE
Development

No branches or pull requests
1 participant
@simonbasle