Collect operator should support doOnDiscard for Iterable items #1924
Labels
type/enhancement
A general enhancement
Milestone
Comments
simonbasle
added a commit
that referenced
this issue
Nov 29, 2019
- Flux.collect(Supplier, BiConsumer) now detects if the container is of type Collection, in which case it discards each element in the collection when appropriate - the operator also now additionally discard the element T along the container when the collector function fails - Flux.collect(Collector) now also discards elements in a similar fashion to Flux.collect(Supplier, BiConsumer). The accumulator failure case and finisher Function failure case are taken into account. The discarding of individual elements inside a Collection is applied to the intermediate container, not the result of the finisher() Behavior change: if you extend Operators.MonoSubscriber, keep the following in mind: `discard(O v)` no longer nulls out the `this.value` field. Calling methods now need to do that themselves instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm using
Flux#collectwith aSupplierfor a customList<DataBuffer>to limits the total number of bytes buffered. HoweverdoOnDiscarddoes not work for the items in theListas it does withcollectList(). This is understandable for a custom, opaque container, but if the container is aCollectionorIterablethen perhaps individual items should be discarded.The text was updated successfully, but these errors were encountered: