-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add missing import statement #5664
base: main
Are you sure you want to change the base?
Conversation
Hi @skoyah! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
These react imports might not be needed 🤔. constantly throughout the documentation we don't have react imported I guess. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
I come from Vueland and is my first contact with React. Started following the tutorial and encountered this "error". |
It should work even if we remove the import of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great and working fine with several tests ...
keep it up mate @skoyah
So perhaps we should remove it from the sandbox itself? Having that import statement does not add anything. Beginners might even wonder why is there in the first place. |
The current Beta documentation shows a code snippet a little different from the one available in the Sandbox.
It seems that the
React
import is missing from the documentation.Steps to reproduce:
This PR fixes the documentation to be in sync with the sandbox example.