Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing import statement #5664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skoyah
Copy link

@skoyah skoyah commented Mar 10, 2023

The current Beta documentation shows a code snippet a little different from the one available in the Sandbox.

It seems that the React import is missing from the documentation.

Steps to reproduce:

Screenshot 2023-03-10 at 18 47 17

Screenshot 2023-03-10 at 20 05 06

This PR fixes the documentation to be in sync with the sandbox example.

@facebook-github-bot
Copy link
Collaborator

Hi @skoyah!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@skoyah skoyah changed the title add missing import statement to the beta docs docs: add missing import statement Mar 10, 2023
@harish-sethuraman
Copy link
Collaborator

These react imports might not be needed 🤔. constantly throughout the documentation we don't have react imported I guess.

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@skoyah
Copy link
Author

skoyah commented Mar 10, 2023

I come from Vueland and is my first contact with React. Started following the tutorial and encountered this "error".

@harish-sethuraman
Copy link
Collaborator

It should work even if we remove the import of React in the codesandbox and it should be fine.

Copy link

@shaonkabir8 shaonkabir8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great and working fine with several tests ...
keep it up mate @skoyah

@skoyah
Copy link
Author

skoyah commented Mar 14, 2023

So perhaps we should remove it from the sandbox itself?

Having that import statement does not add anything.

Beginners might even wonder why is there in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants