-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for handling multiple options with <select> #531
Open
nupurgrover
wants to merge
5
commits into
reactjs:main
Choose a base branch
from
nupurgrover:add-docs-for-multiple-select
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cb76594
Added documentation for handling multiple options with <select>.
16f3254
Fixed indentation.
91f6b7f
Revert "Fixed indentation."
ed03a35
Fixed indentation.
cf3fcd6
Merge branch 'master' into add-docs-for-multiple-select
nupurgrover File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,13 +182,35 @@ class FlavorForm extends React.Component { | |
|
||
Overall, this makes it so that `<input type="text">`, `<textarea>`, and `<select>` all work very similarly - they all accept a `value` attribute that you can use to implement a controlled component. | ||
|
||
> Note | ||
> | ||
> You can pass an array into the `value` attribute, allowing you to select multiple options in a `select` tag: | ||
> | ||
>```js | ||
><select multiple={true} value={['B', 'C']}> | ||
>``` | ||
### Handling multiple options with `<select>` | ||
|
||
It is also possible to select multiple options within a `<select>` tag, by enabling the `multiple` attribute and passing an array into the `value` attribute. This array should contain the corresponding `value` attributes of the `<option>` tags inside the `<select>` tag. | ||
|
||
The `handleChange` method from the above example would then change to get the selected values from `event.target.selectedOptions`. | ||
|
||
```javascript{4,10-12,24} | ||
handleChange(event) { | ||
const selectedFlavors = Array.from(event.target.selectedOptions).map(function(option){ | ||
return option.value; | ||
}); | ||
this.setState({value: selectedFlavors}); | ||
} | ||
``` | ||
|
||
The `<select>` inside the render would also change to pass an array to the `value` attribute: | ||
|
||
```javascript{4,10-12,24} | ||
<select value={this.state.value} onChange={this.handleChange} multiple={true}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2 spaces indentation. |
||
<option value="grapefruit">Grapefruit</option> | ||
<option value="lime">Lime</option> | ||
<option value="coconut">Coconut</option> | ||
<option value="mango">Mango</option> | ||
</select> | ||
``` | ||
|
||
[Try it on CodePen.](https://codepen.io/nupgrover/pen/RxeqLQ?editors=0010) | ||
|
||
|
||
## The file input Tag | ||
|
||
In HTML, an `<input type="file">` lets the user choose one or more files from their device storage to be uploaded to a server or manipulated by JavaScript via the [File API](https://developer.mozilla.org/en-US/docs/Web/API/File/Using_files_from_web_applications). | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation is inconsistent for the rest of this page, which is 2 spaces for both HTML and JS. Do fix your markup accordingly (not sure if Prettier does that for you).
Also, you can simplify
handleChange
to:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yangshun Done. I was not sure if using arrow functions was OK for the docs or not, that is why decided to write it using
function