Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top level API link to header nav #178

Closed
wants to merge 1 commit into from
Closed

Add top level API link to header nav #178

wants to merge 1 commit into from

Conversation

ismamz
Copy link
Contributor

@ismamz ismamz commented Oct 18, 2017

In reference to: #171

captura de pantalla 2017-10-18 a la s 16 26 11

  • Reference group in Docs sidebar was removed
  • Reference content was moved to content/api
  • Added "API" link to header nav
  • content/api pages, redirect from content/docs

This is how it looks on mobile:

@bvaughn It's everything ok?

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit df549aa

https://deploy-preview-178--reactjs.netlify.com

@bvaughn
Copy link
Contributor

bvaughn commented Oct 18, 2017

Hi @ismamz. Whether or not we add the top-level link is still being discussed on #171 😄

Let's see what the consensus is, and if we decide to add it then I'll review this PR!

@ismamz
Copy link
Contributor Author

ismamz commented Oct 18, 2017

Ah ok! I understand. I assumed that there was consensus. You can see how it would look! 😄

@bvaughn
Copy link
Contributor

bvaughn commented Oct 18, 2017

No worries, and much appreciated 😄

@alexkrolick alexkrolick mentioned this pull request Nov 13, 2017
4 tasks
@ismamz ismamz closed this May 17, 2020
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
BetterZxx pushed a commit to BetterZxx/react.dev that referenced this pull request Mar 21, 2023
…actjs#178)

* feat: translate cra v2 blog

* Update 2018-10-01-create-react-app-v2.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants