Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The browser "back" button doesn't work #787

Open
mvasin opened this issue Apr 10, 2018 · 11 comments · May be fixed by #6614
Open

The browser "back" button doesn't work #787

mvasin opened this issue Apr 10, 2018 · 11 comments · May be fixed by #6614

Comments

@mvasin
Copy link
Contributor

mvasin commented Apr 10, 2018

The browser "back" button doesn't work after clicking a fragment link (/page => /page#something).

URL changes back from /page#something to /page, but it has no effect on the scroll position.

@mvasin
Copy link
Contributor Author

mvasin commented Apr 10, 2018

To be precise, after navigating from /page#something1 to /page#something2 the back button works. But if you open a /page and scroll down, then click a link that takes you to /page#something, the back button won't take you back (to the scroll position you were at).

@webbdays
Copy link

can i work on this?

@shubhangii0324
Copy link

I am working on this!

@rickhanlonii
Copy link
Member

Update: this still seems broken on the new react.dev site. It works sometimes but not all the time.

@rickhanlonii
Copy link
Member

If you want to fix this, please just submit a PR, no need to ask to be assigned.

@trevlee0212
Copy link

will try to work on this issue

@pwbriggs
Copy link

pwbriggs commented Feb 5, 2024

@trevlee0212 go ahead, thanks for the help! Submit a PR when you have a working fix.

@trevlee0212 trevlee0212 linked a pull request Feb 7, 2024 that will close this issue
@trevlee0212
Copy link

@pwbriggs PR submitted!

@mannika763
Copy link

I noticed that this issue hasn't been addressed since February. I was able to reproduce the bug and would like to work on fixing it. Has it already been resolved?

@mannika763
Copy link

Also, could you provide a video description?

@trevlee0212
Copy link

trevlee0212 commented Jun 17, 2024

@mannika763 my PR #6614 basically provided the solution for fixing the bug. Just waiting for it to get reviewed.
But feel free to contribute if you have any other (or better) solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants