Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation results in a blank page. #298

Open
5achinJani opened this issue Nov 17, 2017 · 4 comments
Open

Navigation results in a blank page. #298

5achinJani opened this issue Nov 17, 2017 · 4 comments

Comments

@5achinJani
Copy link

image

Steps to reproduce:
-> Type in the URL bar: https://reactjs.org and press Enter.
-> Click on 'Docs' link in the header and watch the page break.

Browser: Chrome Version 62.0.3202.94 (Official Build) (64-bit)
System: Windows 8.1

@bvaughn
Copy link
Contributor

bvaughn commented Nov 17, 2017

Can't reproduce. I have from time to time seen broken navigation issues though (eg clicking a link on the header or sidebar does nothing, minified errors in the console). Every time it's resolved by reloading the page, but it's troubling.

cc @KyleAMathews Have you seen any similar reports? I didn't spot anything obviously related to this while searching Gatsby's GitHub, but you'd probably have a better idea.

@KyleAMathews
Copy link
Contributor

Occasionally — I want to add JS error tracking soon to gatsbyjs.org. Are you running any on reactjs.org?

It's hard as a maintainer to know what the occasional report means though as there's plenty of ways to create errors in your own code. Which is why adding error tracking on a site I control gatsbyjs.org would be a great start.

Also want to rewrite the gatsby runtime soon (maybe in Reason) with particular attention paid on catching all the errors Gatsby can handle.

It might make sense to add some sort of error boundary to Gatsby so that even if people ship buggy code, it won't break Gatsby altogether.

@bvaughn
Copy link
Contributor

bvaughn commented Nov 17, 2017

It's hard as a maintainer to know what the occasional report means though as there's plenty of ways to create errors in your own code.

Totally! In my case, I see it from time to time on reactjs.org, in between passing builds, so I think there's something there. I just haven't identified a pattern yet because it's infrequent.

I want to add JS error tracking soon to gatsbyjs.org. Are you running any on reactjs.org?

Nope. We should. I'll update #9 to include this. If you add it to GatsbyJS.org first, I'd love to lazily copy your implementation.

@mjasnowski
Copy link

I'm wondering if this is still valid or if the original links have been changed since the issue was reported. Just clicking on "Docs" from the reactjs.org page does not lead to the page in the original post. I can physically type that address and it appears, but not from the "Docs" link in the navigation bar.

The original post is showing this page was visited by clicking on the "Docs" link from the main page:

https://reactjs.org/docs/hello-world.html


As of today it links to

https://reactjs.org/docs/getting-started.html


There is a "hello world" link in the first page of the documentation but it directs out to codepen.io. The only other way I've seen so far to reach "hello-world.html" was to click on "Docs > Main Concepts > Hello World", but didn't see those errors in the javascript console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants