-
-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use anchor tags as Tab links #250
Comments
Please let me know if this is desired, if so I'd be happy to submit a PR 👍 |
Agreed. Use basic html rather than scripting Take the example with Avengers icons in the tabs: http://reactcommunity.org/react-tabs/ |
I think this would be good for SEO. Most of my content is accessed via tabs and I'm not sure that search bots are seeing it. For now I'm using anchors inside the tabs like this: <TabList>
<Tab><a>Title 1</a></Tab>
<Tab><a>Title 2</a></Tab>
</TabList> |
It wouldn't necessarily be a link, either, as a button could be appropriate depending on the context, too. A link could suggest:
A button would be appropriate if you're changing content without affecting the URL. Defaulting to a link or button, and allowing the user to override the tag would likely be a good approach while maintaining semantic use of the HTML tags used for interaction |
will this ever be implemented? will b e great to have this |
I think it'd be better for semantics to use
<a>
tags instead of<li>
tags for the Tab buttons.This article reminded me of this, stating that
I reckon a tab usually does change most of the page's content, so we should use anchor tags.
The text was updated successfully, but these errors were encountered: