This repository was archived by the owner on Oct 26, 2018. It is now read-only.
Init currentLocation to initial location from the store#403
Merged
Conversation
This solves the problem when the server has initialised the state and the user already has things in their history. Without this change a superfluous action will be pushed with the same URL that the user is already looking at resulting in that we would need to use the back button twice. Resolves reactjs#313
This was referenced Jun 3, 2016
Changed react-router-redux to a temporary fork that fixes routing
rocjs/roc-package-web-app-react#20
Merged
Contributor
|
Thank you for this! Sorry for the delay on the review. I'm prepping our house for our first kid, so things have been crazy at home. And I wanted to give this the right attention. I'll push out a new version shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the problem when the server has initialised the state and the user already has things in their history.
Without this change a superfluous action will be pushed with the same URL that the user is already looking at resulting in that we would need to use the back button twice.
Resolves #313