Skip to content

TypeScript interface augmentation for SymbolConstructor conflicts with symbol-observable #3697

Closed
@aikoven

Description

RxJS version:

6.1.0

Code to reproduce:

Include rxjs@6.1.0 and symbol-observable@1.2.0 into compilation

Expected behavior:

No TypeScript errors

Actual behavior:

TypeScript error

node_modules/rxjs/internal/symbol/observable.d.ts(4,9): error TS2687: 
    All declarations of 'observable' must have identical modifiers.

Additional information:

Type definition from symbol-observable:

declare global {
  export interface SymbolConstructor {
    readonly observable: symbol;
  }
}

Type definition from rxjs:

declare global {
  interface SymbolConstructor {
    observable: symbol;
  }
}

Note the difference in readonly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugConfirmed bughelp wantedIssues we wouldn't mind assistance with.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions