Integrated lambda with rxjava2 (#6)

Author: Ashwini Kumar

app/src/main/java/com/esoxjem/movieguide/details/MovieDetailsPresenter.java

@@ -5,7 +5,6 @@
 
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.disposables.CompositeDisposable;
-import io.reactivex.observers.DisposableObserver;
 import io.reactivex.schedulers.Schedulers;
 
 /**
@@ -58,64 +57,47 @@ public void showTrailers(Movie movie)
         compositeDisposable.add(movieDetailsEndpoint.getMovieTrailers(movie.getId())
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
-                .subscribeWith(new DisposableObserver<VideoViewModel>()
-                {
-                    @Override
-                    public void onNext(VideoViewModel videoViewModel)
-                    {
-                        if (isViewAttached())
-                        {
-                            view.showTrailers(videoViewModel.getVideos());
-                        }
-                    }
-
-                    @Override
-                    public void onError(Throwable e)
-                    {
-
-                    }
-
-                    @Override
-                    public void onComplete()
-                    {
-
-                    }
-                }));
+                .subscribe(this::onTrailersResult, throwable -> onError()));
     }
 
+    private void onError()
+    {
+        // do nothing
+    }
+
+    private void onTrailersResult(VideoViewModel videoViewModel)
+    {
+        if (isViewAttached())
+        {
+            view.showTrailers(videoViewModel.getVideos());
+        } else
+        {
+            // do nothing
+        }
+    }
 
     @Override
     public void showReviews(Movie movie)
     {
         compositeDisposable.add(movieDetailsEndpoint.getMovieReviews(movie.getId())
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
-                .subscribeWith(new DisposableObserver<ReviewViewModel>()
-                {
-                    @Override
-                    public void onNext(ReviewViewModel reviewViewModel)
-                    {
-                        if (isViewAttached())
-                        {
-                            view.showReviews(reviewViewModel.getReviews());
-                        }
-                    }
-
-                    @Override
-                    public void onError(Throwable e)
-                    {
-
-                    }
-
-                    @Override
-                    public void onComplete()
-                    {
-
-                    }
-                }));
+                .subscribe(this::onReviewsResult, throwable -> onError()));
 
     }
 
+    private void onReviewsResult(ReviewViewModel reviewViewModel)
+    {
+
+        if (isViewAttached())
+        {
+            view.showReviews(reviewViewModel.getReviews());
+        } else
+        {
+            // do nothing
+        }
+    }
+
     @Override
     public void showFavoriteButton(Movie movie)
     {

app/src/main/java/com/esoxjem/movieguide/listing/MoviesListingPresenter.java

@@ -6,7 +6,6 @@
 
 import io.reactivex.android.schedulers.AndroidSchedulers;
 import io.reactivex.disposables.CompositeDisposable;
-import io.reactivex.observers.DisposableObserver;
 import io.reactivex.schedulers.Schedulers;
 
 /**
@@ -68,26 +67,30 @@ private void loadPopularMovies()
                         view.loadingStarted();
                     }
                 })
-                .subscribeWith(new DisposableObserver<MovieViewModel>()
-                {
-                    @Override
-                    public void onComplete()
-                    {
+                .subscribe(this::onMoviewsResult, this::onError));
+    }
 
-                    }
+    private void onMoviewsResult(MovieViewModel movieViewModel)
+    {
+        if (isViewAttached())
+        {
+            view.showMovies(movieViewModel.getMovies());
+        } else
+        {
+            // do nothing
+        }
+    }
 
-                    @Override
-                    public void onError(Throwable e)
-                    {
-                        view.loadingFailed(e.getMessage());
-                    }
 
-                    @Override
-                    public void onNext(MovieViewModel movieViewModel)
-                    {
-                        view.showMovies(movieViewModel.getMovies());
-                    }
-                }));
+    private void onError(Throwable throwable)
+    {
+        if (isViewAttached())
+        {
+            view.loadingFailed(throwable.getMessage());
+        } else
+        {
+            // do nothing
+        }
     }
 
     private void loadHighestRatedMovies()
@@ -101,26 +104,7 @@ private void loadHighestRatedMovies()
                         view.loadingStarted();
                     }
                 })
-                .subscribeWith(new DisposableObserver<MovieViewModel>()
-                {
-                    @Override
-                    public void onComplete()
-                    {
-
-                    }
-
-                    @Override
-                    public void onError(Throwable e)
-                    {
-                        view.loadingFailed(e.getMessage());
-                    }
-
-                    @Override
-                    public void onNext(MovieViewModel movieViewModel)
-                    {
-                        view.showMovies(movieViewModel.getMovies());
-                    }
-                }));
+                .subscribe(this::onMoviewsResult, this::onError));
     }
 
     private void loadFavouriteMovies()