Fix disabling webhook mentions when bot lacks permissions

Author: Throne3d

lib/bot.js

@@ -594,9 +594,8 @@ class Bot {
       const username = _.padEnd(author.substring(0, USERNAME_MAX_LENGTH), USERNAME_MIN_LENGTH, '_');
       webhook.client.send(withMentions, {
         username,
-        text,
         avatarURL,
-        disableEveryone: !canPingEveryone,
+        disableMentions: canPingEveryone ? 'none' : 'everyone',
       }).catch(logger.error);
       return;
     }

test/bot.test.js

@@ -1001,9 +1001,8 @@ describe('Bot', function () {
       this.bot.sendToDiscord('n', '#irc', text);
       this.sendWebhookMessageStub.should.have.been.calledWith(text, {
         username: 'n_',
-        text,
         avatarURL: null,
-        disableEveryone: true,
+        disableMentions: 'everyone',
       });
     });
 
@@ -1012,9 +1011,8 @@ describe('Bot', function () {
       this.bot.sendToDiscord('1234567890123456789012345678901234567890', '#irc', text);
       this.sendWebhookMessageStub.should.have.been.calledWith(text, {
         username: '12345678901234567890123456789012',
-        text,
         avatarURL: null,
-        disableEveryone: true,
+        disableMentions: 'everyone',
       });
     });
 
@@ -1029,9 +1027,8 @@ describe('Bot', function () {
       this.bot.sendToDiscord('nick', '#irc', text);
       this.sendWebhookMessageStub.should.have.been.calledWith(text, {
         username: 'nick',
-        text,
         avatarURL: null,
-        disableEveryone: true,
+        disableMentions: 'everyone',
       });
     });
 
@@ -1047,9 +1044,8 @@ describe('Bot', function () {
       this.bot.sendToDiscord('nick', '#irc', text);
       this.sendWebhookMessageStub.should.have.been.calledWith(text, {
         username: 'nick',
-        text,
         avatarURL: null,
-        disableEveryone: false,
+        disableMentions: 'none',
       });
     });