Skip to content

Commit e3598fa

Browse files
javachemeta-codesync[bot]
authored andcommitted
Remove FileIoHandler (#58096)
Summary: Pull Request resolved: #58096 This was added ages to serve an internal use-case and is a major security risk if left unguarded in production (D4650999 / S670581). It was never ported to iOS and a platform inconsistency. Changelog: [Android][Changed] Removed FileIoHandler packager message handlers (Not breaking since this is a devtooling-related API change: https://reactnative.dev/releases/versioning-policy#what-is-a-breaking-change) Reviewed By: christophpurrer, cortinico Differential Revision: D117176703 fbshipit-source-id: c79cb8d7758706b1871f81e72c6e356ae32ed6a9
1 parent 5b680c5 commit e3598fa

3 files changed

Lines changed: 0 additions & 171 deletions

File tree

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2960,12 +2960,6 @@ public abstract interface class com/facebook/react/modules/websocket/WebSocketMo
29602960
public abstract fun onMessage (Lokio/ByteString;Lcom/facebook/react/bridge/WritableMap;)V
29612961
}
29622962

2963-
public final class com/facebook/react/packagerconnection/FileIoHandler : java/lang/Runnable {
2964-
public fun <init> ()V
2965-
public final fun handlers ()Ljava/util/Map;
2966-
public fun run ()V
2967-
}
2968-
29692963
public final class com/facebook/react/packagerconnection/JSPackagerClient : com/facebook/react/packagerconnection/ReconnectingWebSocket$MessageCallback {
29702964
public fun <init> (Ljava/lang/String;Lcom/facebook/react/packagerconnection/PackagerConnectionSettings;Ljava/util/Map;)V
29712965
public fun <init> (Ljava/lang/String;Lcom/facebook/react/packagerconnection/PackagerConnectionSettings;Ljava/util/Map;Lcom/facebook/react/packagerconnection/ReconnectingWebSocket$ConnectionCallback;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import com.facebook.react.devsupport.interfaces.PackagerStatusCallback
2727
import com.facebook.react.modules.debug.interfaces.DeveloperSettings
2828
import com.facebook.react.modules.systeminfo.AndroidInfoHelpers.getFriendlyDeviceName
2929
import com.facebook.react.modules.systeminfo.AndroidInfoHelpers.getInspectorHostMetadata
30-
import com.facebook.react.packagerconnection.FileIoHandler
3130
import com.facebook.react.packagerconnection.JSPackagerClient
3231
import com.facebook.react.packagerconnection.NotificationOnlyHandler
3332
import com.facebook.react.packagerconnection.PackagerConnectionSettings
@@ -160,7 +159,6 @@ public open class DevServerHelper(
160159
}
161160
}
162161
commandListener.customCommandHandlers()?.let { handlers.putAll(it) }
163-
handlers.putAll(FileIoHandler().handlers())
164162

165163
val onPackagerConnectedCallback: ReconnectingWebSocket.ConnectionCallback =
166164
object : ReconnectingWebSocket.ConnectionCallback {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/FileIoHandler.kt

Lines changed: 0 additions & 163 deletions
This file was deleted.

0 commit comments

Comments
 (0)