Skip to content

Commit cd69b25

Browse files
javachemeta-codesync[bot]
authored andcommitted
Drop cxxreact dep from performance/cdpmetrics + timeline Package.swift (#57446)
Summary: Pull Request resolved: #57446 Catch the Swift Package definitions up to BUCK reality: the BUCK targets for `react/performance/cdpmetrics` and `react/performance/timeline` are already independent of `cxxreact` (`React-cxxreact`/`React-cxxreact` is not in either of their `deps`), but `Package.swift` was still declaring the OSS-side dep. Drop `.reactCxxReact` from both `RNTarget` definitions. iOS/Swift-Package-only change. No code or BUCK changes. Changelog: [Internal] Reviewed By: zeyap Differential Revision: D108786497 fbshipit-source-id: 2258a9f6e755118d0ef671bbceeded5c2546b913
1 parent 703e362 commit cd69b25

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

packages/react-native/Package.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,15 +243,15 @@ let reactPerformanceCdpMetrics = RNTarget(
243243
name: .reactPerformanceCdpMetrics,
244244
path: "ReactCommon/react/performance/cdpmetrics",
245245
excludedPaths: ["tests"],
246-
dependencies: [.reactNativeDependencies, .reactCxxReact, .jsi, .reactPerformanceTimeline, .reactRuntimeExecutor]
246+
dependencies: [.reactNativeDependencies, .jsi, .reactPerformanceTimeline, .reactRuntimeExecutor]
247247
)
248248

249249
/// React-performancetimeline.podspec
250250
let reactPerformanceTimeline = RNTarget(
251251
name: .reactPerformanceTimeline,
252252
path: "ReactCommon/react/performance/timeline",
253253
excludedPaths: ["tests"],
254-
dependencies: [.reactNativeDependencies, .reactFeatureFlags, .reactJsInspectorTracing, .reactCxxReact, .reactPerfLogger]
254+
dependencies: [.reactNativeDependencies, .reactFeatureFlags, .reactJsInspectorTracing, .reactPerfLogger]
255255
)
256256

257257
/// React-runtimescheduler.podspec

0 commit comments

Comments
 (0)