Skip to content

Commit ebe2970

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored andcommitted
RPP: add label to FRE dialog for auto annotations
Fixed: 406541372 Change-Id: I054a33b806f73f1346d8abebf62c48aa51ecd8dd Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6401153 Commit-Queue: Alina Varkki <alinavarkki@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Alina Varkki <alinavarkki@chromium.org> Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
1 parent 5e8e4b8 commit ebe2970

3 files changed

Lines changed: 15 additions & 1 deletion

File tree

‎front_end/panels/common/common.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ export class FreDialog {
4444
header,
4545
reminderItems,
4646
onLearnMoreClick,
47+
ariaLabel,
4748
}: {
4849
header: {
4950
iconName: string,
@@ -54,8 +55,12 @@ export class FreDialog {
5455
content: Platform.UIString.LocalizedString|Lit.LitTemplate,
5556
}>,
5657
onLearnMoreClick: () => void,
58+
ariaLabel?: string,
5759
}): Promise<boolean> {
5860
const dialog = new UI.Dialog.Dialog();
61+
if (ariaLabel) {
62+
dialog.setAriaLabel(ariaLabel);
63+
}
5964
const result = Promise.withResolvers<boolean>();
6065
// clang-format off
6166
Lit.render(html`

‎front_end/panels/timeline/overlays/components/EntryLabelOverlay.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ const UIStrings = {
4242
*@description Text displayed on a button that generates an AI label.
4343
*/
4444
generateLabelButton: 'Generate label',
45+
/**
46+
*@description Label used for screenreaders on the FRE dialog
47+
*/
48+
freDialog: 'Get AI-powered annotation suggestions dialog'
4549
} as const;
4650

4751
/*
@@ -479,7 +483,7 @@ export class EntryLabelOverlay extends HTMLElement {
479483
try {
480484
// Trigger a re-render to display the loading component in the place of the button when the label is being generated.
481485
this.#isAILabelLoading = true;
482-
await void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
486+
void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
483487

484488
this.#label = await this.#performanceAgent.generateAIEntryLabel(this.#callTree);
485489
this.dispatchEvent(new EntryLabelChangeEvent(this.#label));
@@ -512,6 +516,7 @@ export class EntryLabelOverlay extends HTMLElement {
512516
*/
513517
async #showUserAiFirstRunDialog(): Promise<boolean> {
514518
const userConsented = await PanelCommon.FreDialog.show({
519+
ariaLabel: i18nString(UIStrings.freDialog),
515520
header: {iconName: 'pen-spark', text: lockedString(UIStringsNotTranslate.freDisclaimerHeader)},
516521
reminderItems: [
517522
{

‎front_end/ui/legacy/Dialog.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ export class Dialog extends Common.ObjectWrapper.eventMixin<EventTypes, typeof G
103103
Dialog.instance = null;
104104
}
105105

106+
setAriaLabel(label: string): void {
107+
ARIAUtils.setLabel(this.contentElement, label);
108+
}
109+
106110
setCloseOnEscape(close: boolean): void {
107111
this.closeOnEscape = close;
108112
}

0 commit comments

Comments
 (0)