Move unittests karma config out of the frontend folder

Change-Id: I06e28e5a9afbbf7daa569a9b699c60e4554ed5a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2395404
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>

Author: OrKoN

scripts/test/run_unittests.py

@@ -24,7 +24,8 @@
 
 def run_tests(chrome_binary, target, no_text_coverage, coverage):
     cwd = devtools_paths.devtools_root_path()
-    karmaconfig_path = os.path.join(cwd, 'out', target, 'gen', 'test', 'unittests', 'front_end', 'karma.conf.js')
+    karmaconfig_path = os.path.join(cwd, 'out', target, 'gen', 'test',
+                                    'unittests', 'karma.conf.js')
 
     if not os.path.exists(karmaconfig_path):
         print('Unable to find Karma config at ' + karmaconfig_path)
@@ -43,7 +44,6 @@ def run_tests(chrome_binary, target, no_text_coverage, coverage):
         env['COVERAGE'] = '1'
     if (chrome_binary is not None):
         env['CHROME_BIN'] = chrome_binary
-
     exit_code = test_helpers.popen(exec_command, cwd=cwd, env=env)
     if exit_code == 1:
         return True

test/BUILD.gn

@@ -7,6 +7,6 @@ group("test") {
     "e2e",
     "perf",
     "shared",
-    "unittests/front_end",
+    "unittests",
   ]
 }

test/unittests/BUILD.gn

@@ -0,0 +1,17 @@
+import("../../scripts/build/ninja/copy.gni")
+
+# Copyright 2020 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+group("unittests") {
+  deps = [
+    ":copy_to_gen",
+    "front_end",
+  ]
+}
+
+copy("copy_to_gen") {
+  sources = [ "karma.conf.js" ]
+  outputs = [ "$target_gen_dir/karma.conf.js" ]
+}

test/unittests/front_end/BUILD.gn

@@ -2,11 +2,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import("../../../scripts/build/ninja/copy.gni")
-
 group("front_end") {
   deps = [
-    ":copy_karma_conf",
     "../../../front_end/Images",
     "bindings",
     "browser_sdk",
@@ -31,8 +28,3 @@ group("front_end") {
     "ui",
   ]
 }
-
-copy("copy_karma_conf") {
-  sources = [ "karma.conf.js" ]
-  outputs = [ "$target_gen_dir/karma.conf.js" ]
-}

test/unittests/front_end/karma.conf.js test/unittests/karma.conf.jstest/unittests/front_end/karma.conf.js renamed to test/unittests/karma.conf.js

@@ -13,32 +13,40 @@ const COVERAGE_ENABLED = !!process.env['COVERAGE'];
 // true by default
 const TEXT_COVERAGE_ENABLED = COVERAGE_ENABLED && !process.env['NO_TEXT_COVERAGE'];
 
-const GEN_DIRECTORY = path.join(__dirname, '..', '..', '..');
+const GEN_DIRECTORY = path.join(__dirname, '..', '..');
 const ROOT_DIRECTORY = path.join(GEN_DIRECTORY, '..', '..', '..');
-
 const browsers = DEBUG_ENABLED ? ['Chrome'] : ['ChromeHeadless'];
 
 const coverageReporters = COVERAGE_ENABLED ? ['coverage'] : [];
 const coveragePreprocessors = COVERAGE_ENABLED ? ['coverage'] : [];
 const commonIstanbulReporters = [{type: 'html'}, {type: 'json-summary'}];
-const istanbulReportOutputs = TEXT_COVERAGE_ENABLED ? [{type: 'text'}, ...commonIstanbulReporters] : commonIstanbulReporters;
+const istanbulReportOutputs =
+    TEXT_COVERAGE_ENABLED ? [{type: 'text'}, ...commonIstanbulReporters] : commonIstanbulReporters;
 
-const UNIT_TESTS_FOLDER = path.join(ROOT_DIRECTORY, 'test', 'unittests', 'front_end');
-const TEST_SOURCES = path.join(UNIT_TESTS_FOLDER, '**/*.ts');
+const UNIT_TESTS_ROOT_FOLDER = path.join(ROOT_DIRECTORY, 'test', 'unittests');
+const UNIT_TESTS_FOLDERS = [
+  path.join(UNIT_TESTS_ROOT_FOLDER, 'front_end'),
+];
+const TEST_SOURCES = UNIT_TESTS_FOLDERS.map(folder => path.join(folder, '**/*.ts'));
 
 // To make sure that any leftover JavaScript files (e.g. that were outputs from now-removed tests)
 // aren't incorrectly included, we glob for the TypeScript files instead and use that
 // to instruct Mocha to run the output JavaScript file.
-const TEST_FILES = glob.sync(TEST_SOURCES).map(fileName => {
-  const jsFile = fileName.replace(/\.ts$/, '.js');
-  const generatedJsFile = path.join(__dirname, path.relative(UNIT_TESTS_FOLDER, jsFile));
-
-  if (!fs.existsSync(generatedJsFile)) {
-    throw new Error(`Test file ${fileName} is not included in a BUILD.gn and therefore will not be run.`);
-  }
+const TEST_FILES =
+    TEST_SOURCES
+        .map(source => {
+          return glob.sync(source).map(fileName => {
+            const jsFile = fileName.replace(/\.ts$/, '.js');
+            const generatedJsFile = path.join(__dirname, path.relative(UNIT_TESTS_ROOT_FOLDER, jsFile));
+            if (!fs.existsSync(generatedJsFile)) {
+              throw new Error(`Test file ${fileName} is not included in a BUILD.gn and therefore will not be run.`);
+            }
+
+            return generatedJsFile;
+          });
+        })
+        .flat();
 
-  return generatedJsFile;
-});
 
 const TEST_FILES_SOURCE_MAPS = TEST_FILES.map(fileName => `${fileName}.map`);
 
@@ -49,14 +57,16 @@ module.exports = function(config) {
     files: [
       ...TEST_FILES.map(pattern => ({pattern, type: 'module'})),
       ...TEST_FILES_SOURCE_MAPS.map(pattern => ({pattern, served: true, included: false})),
-      {pattern: TEST_SOURCES, served: true, included: false},
+      ...TEST_SOURCES.map(source => ({pattern: source, served: true, included: false})),
       {pattern: path.join(GEN_DIRECTORY, 'front_end/Images/*.{svg,png}'), served: true, included: false},
       {pattern: path.join(GEN_DIRECTORY, 'front_end/**/*.css'), served: true, included: false},
       {pattern: path.join(GEN_DIRECTORY, 'front_end/**/*.js'), served: true, included: false},
       {pattern: path.join(GEN_DIRECTORY, 'front_end/**/*.js.map'), served: true, included: false},
       {pattern: path.join(GEN_DIRECTORY, 'front_end/**/*.mjs'), served: true, included: false},
       {pattern: path.join(GEN_DIRECTORY, 'front_end/**/*.mjs.map'), served: true, included: false},
       {pattern: path.join(ROOT_DIRECTORY, 'front_end/**/*.ts'), served: true, included: false},
+      {pattern: path.join(GEN_DIRECTORY, 'inspector_overlay/**/*.js'), served: true, included: false},
+      {pattern: path.join(GEN_DIRECTORY, 'inspector_overlay/**/*.js.map'), served: true, included: false},
     ],
 
     reporters: [