Skip to content

Commit 42943d8

Browse files
authored
fix(DropdownMenu): remove defaultProps (#103)
1 parent ba3d534 commit 42943d8

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

src/DropdownMenu.tsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,6 @@ export function useDropdownMenu(options: UseDropdownMenuOptions = {}) {
176176
return [menuProps, metadata] as const;
177177
}
178178

179-
const defaultProps = {
180-
usePopper: true,
181-
};
182-
183179
export interface DropdownMenuProps extends UseDropdownMenuOptions {
184180
/**
185181
* A render prop that returns a Menu element. The `props`
@@ -214,15 +210,20 @@ export interface DropdownMenuProps extends UseDropdownMenuOptions {
214210
* @displayName DropdownMenu
215211
* @memberOf Dropdown
216212
*/
217-
function DropdownMenu({ children, ...options }: DropdownMenuProps) {
218-
const [props, meta] = useDropdownMenu(options);
213+
function DropdownMenu({
214+
children,
215+
usePopper: usePopperProp = true,
216+
...options
217+
}: DropdownMenuProps) {
218+
const [props, meta] = useDropdownMenu({
219+
...options,
220+
usePopper: usePopperProp,
221+
});
219222

220223
return <>{children(props, meta)}</>;
221224
}
222225

223226
DropdownMenu.displayName = 'DropdownMenu';
224227

225-
DropdownMenu.defaultProps = defaultProps;
226-
227228
/** @component */
228229
export default DropdownMenu;

0 commit comments

Comments
 (0)