feat: add snacks to api reference docs #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdnk
reviewed
Jan 22, 2020
| ```js | ||
| import { CommonActions } from '@react-navigation/native'; | ||
|
|
||
| navigation.dispatch(CommonActions.setParams({ title: 'Hello' })); | ||
| navigation.dispatch(CommonActions.setParams({ user: 'Wojtek' })); |
| onPress={() => | ||
| navigation.setParams({ | ||
| friends: | ||
| route.params.friends[0] === 'Brent' |
| <DrawerItemList {...props} /> | ||
| <DrawerItem | ||
| label="Close drawer" | ||
| onPress={() => navRef.current.dispatch(DrawerActions.closeDrawer())} |
There was a problem hiding this comment.
Maybe useNavigation() and then just openDrawer()
There was a problem hiding this comment.
You also get navigation in props
There was a problem hiding this comment.
I will use navigation from props then :)
| } from '@react-navigation/drawer'; | ||
| import { DrawerActions } from '@react-navigation/routers'; | ||
|
|
||
| const navRef = React.createRef(null); |
| } from '@react-navigation/drawer'; | ||
| import { DrawerActions } from '@react-navigation/routers'; | ||
|
|
||
| const navRef = React.createRef(null); |
osdnk
reviewed
Jan 22, 2020
| @@ -22,6 +22,7 @@ function Notifications({ navigation }) { | |||
| title="Go to Profile" | |||
| onPress={() => navigation.navigate('Profile')} | |||
| /> | |||
| <Button title="Go Back" onPress={() => navigation.goBack()} /> | |||
| navigation.addListener('focus', () => alert('Screen was focused')) | ||
| ); | ||
|
|
||
| React.useEffect(() => |
There was a problem hiding this comment.
Add array as a second arg (not only here)
| function ProfileScreen({ navigation }) { | ||
| return ( | ||
| <View style={{ flex: 1, alignItems: 'center', justifyContent: 'center' }}> | ||
| <Button title="Go back" onPress={() => navigation.goBack()} /> |
| } | ||
|
|
||
| export default function App() { | ||
| enableScreens(); |
There was a problem hiding this comment.
I think it’s more common to do it in global scope
satya164
reviewed
Jan 22, 2020
docs/material-top-tab-navigator.md
Outdated
| @@ -270,6 +274,7 @@ function MyTabBar({ state, descriptors, navigation, position }) { | |||
| }); | |||
| }; | |||
|
|
|||
| const inputRange = [0, 1, 2]; | |||
There was a problem hiding this comment.
To keep it in sync with number of tabs, I'd do
Suggested change
| const inputRange = [0, 1, 2]; | |
| const inputRange = state.routes.map((_, i) => i); |
| <DrawerItemList {...props} /> | ||
| <DrawerItem | ||
| label="Close drawer" | ||
| onPress={() => navRef.current.dispatch(DrawerActions.closeDrawer())} |
There was a problem hiding this comment.
You also get navigation in props
WoLewicki
force-pushed
the
@wolewicki/add-snacks-to-api-reference-docs
branch
from
2581168 to
45d7739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added snacks to almost all examples and fixed some typos etc.