This repository was archived by the owner on May 26, 2019. It is now read-only.
Feature / Check if phone is busy #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @ianlin ! Can you, please, review this one? |
ianlin
reviewed
Apr 9, 2018
index.js
Outdated
| _RNCallKit.endAllCalls(); | ||
| } | ||
|
|
||
| static checkIfBusy = _RNCallKit.checkIfBusy; |
There was a problem hiding this comment.
I think Android might crash here as we do not check what the platform is like other functions.
|
Hi @aarkalyk can you please have a look on my review? Cheers. |
aarkalyk
force-pushed
the
feature/check-if-busy-method
branch
from
6e6dd73 to
2062113
Compare
|
Hey, @ianlin ! Thanks for the feedback! Can you please take one more look at the PR?:) |
|
Thanks! |
ianlin
added a commit
that referenced
this pull request
May 2, 2018
c09fb17 Method for checking speaker status (#41) (@arkalyk Akash 2018-05-02 17:24:55 +0200) 41b3147 Feature / Check if phone is busy (#39) (@arkalyk Akash 2018-04-19 11:03:00 +0200) c15c147 Feature/method and callback for mic toggle (#40) (@arkalyk Akash 2018-04-19 08:34:47 +0200) 7eee28b README updated. (@arkalyk AKASH 2018-03-14 12:08:40 +0100) 9c74590 README updated. (@arkalyk AKASH 2018-03-14 11:57:16 +0100) 7fbcf0e moved displayIncomingCall callback moved to addEventListener. (@arkalyk AKASH 2018-03-14 11:17:08 +0100) 786d28a README updated. (@arkalyk AKASH 2018-03-05 08:21:58 +0100) a3a4760 minor fix. (@arkalyk AKASH 2018-03-05 07:53:29 +0100) 887580d displayIncomingCall callback added. (@arkalyk AKASH 2018-03-02 14:47:56 +0100) 4211274 README.md updated. (@arkalyk AKASH 2018-03-02 15:10:23 +0100) e29ac6d contactIdentifier added to startCall action. (@arkalyk AKASH 2018-02-14 20:53:32 +0100)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method for checking if there are any active calls on the device.
Pretty convenient to use with the
async/awaitsyntax.