the start call event can be delivered to JS when app is launched via user activity

Author: ianlin

README.md

@@ -7,6 +7,8 @@
 
 For more information about **CallKit**, please see [Official CallKit Framework Document][1] or [Introduction to CallKit by Xamarin][2]
 
+**Note**: Since CallKit is quite new, this module will be updated frequently so be careful with the version you are using.
+
 ## Installation
 
 ### NPM module
@@ -27,23 +29,43 @@ In `Xcode` -> `Build Phases` -> `Link Binary With Libraries`, add `CallKit.frame
 
 ### AppDelegate.m
 
+#### - Import Library
+
 ```obj-c
 #import "RNCallKit.h"
+```
 
-.
-.
-.
+#### - Change the way you initialise React Root View
 
+Initialise **RNCallKit** first, since we need our custom `observer` of `NSNotificationCenter` to be started as soon as the app is initialising
 
-- (BOOL)application:(UIApplication *)application
-            openURL:(NSURL *)url
-            options:(NSDictionary<UIApplicationOpenURLOptionsKey, id> *)options NS_AVAILABLE_IOS(9_0)
-{
+```diff
 
-  return [RNCallKit application:application
-                        openURL:url
-                        options:options];
-}
+// This is how you normally initialise React Root View, delete it
+-RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
+-                                                    moduleName:@"MyApp"
+-                                             initialProperties:nil
+-                                                 launchOptions:launchOptions];
+
+// Initialise RNCallKit
++RNCallKit *rncallkit = [[RNCallKit alloc] init];
+
+// Initialise React Bridge with RNCallKit
++RCTBridge *bridge = [[RCTBridge alloc] initWithBundleURL:jsCodeLocation
++                                          moduleProvider:^{ return @[rncallkit]; }
++                                           launchOptions:launchOptions];
+
+// Initialise React Root View with React Bridge you've just created
++RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
++                                                 moduleName:@"MyApp"
++                                          initialProperties:nil];
+```
+
+#### - Handling User Activity
+
+This delegate will be called when the user tries to start a call from native Phone App
+
+```obj-c
 
 - (BOOL)application:(UIApplication *)application
 continueUserActivity:(NSUserActivity *)userActivity
@@ -174,7 +196,7 @@ class RNCallKitExample extends React.Component {
      */
 
     let _uuid = uuid.v4();
-    RNCallKit.startCall(_uuid, data.handle);    
+    RNCallKit.startCall(_uuid, data.handle);
   }
 
   onRNCallKitPerformAnswerCallAction() {
@@ -187,7 +209,7 @@ class RNCallKitExample extends React.Component {
   }
 
   onRNCallKitPerformEndCallAction() {
-    /* You will get this event when the user finish the incoming/outgoing call 
+    /* You will get this event when the user finish the incoming/outgoing call
      *
      * Try to do your normal Hang Up actions here
      *

index.js

@@ -25,6 +25,7 @@ export default class RNCallKit {
                 RNCallKitDidReceiveStartCallAction,
                 (data) => { handler(data);}
             );
+            _RNCallKit._startCallActionEventListenerAdded();
         } else if (type === 'answerCall') {
             listener = _RNCallKitEmitter.addListener(
                 RNCallKitPerformAnswerCallAction,

ios/RNCallKit/RNCallKit.m

@@ -15,37 +15,43 @@
 
 #import <AVFoundation/AVAudioSession.h>
 
-NSString *const RNCallKitHandleStartCallNotification = @"RNCallKitHandleStartCallNotification";
-NSString *const RNCallKitDidReceiveStartCallAction = @"RNCallKitDidReceiveStartCallAction";
-NSString *const RNCallKitPerformAnswerCallAction = @"RNCallKitPerformAnswerCallAction";
-NSString *const RNCallKitPerformEndCallAction = @"RNCallKitPerformEndCallAction";
-NSString *const RNCallKitDidActivateAudioSession = @"RNCallKitDidActivateAudioSession";
+static int const DelayInSeconds = 2;
+
+static NSString *const RNCallKitHandleStartCallNotification = @"RNCallKitHandleStartCallNotification";
+static NSString *const RNCallKitDidReceiveStartCallAction = @"RNCallKitDidReceiveStartCallAction";
+static NSString *const RNCallKitPerformAnswerCallAction = @"RNCallKitPerformAnswerCallAction";
+static NSString *const RNCallKitPerformEndCallAction = @"RNCallKitPerformEndCallAction";
+static NSString *const RNCallKitDidActivateAudioSession = @"RNCallKitDidActivateAudioSession";
 
 @implementation RNCallKit
 {
     NSMutableDictionary *_settings;
     NSOperatingSystemVersion _version;
+    BOOL _isStartCallActionEventListenerAdded;
 }
 
-RCT_EXPORT_MODULE()
+// should initialise in AppDelegate.m
+//RCT_EXPORT_MODULE()
 
-// Override method of RCTEventEmitter
-- (void)startObserving
+- (instancetype)init
 {
 #ifdef DEBUG
-    NSLog(@"[RNCallKit][startObserving]");
+    NSLog(@"[RNCallKit][init]");
 #endif
-    [[NSNotificationCenter defaultCenter] addObserver:self
-                                             selector:@selector(handleStartCallNotification:)
-                                                 name:RNCallKitHandleStartCallNotification
-                                               object:nil];
+    if (self = [super init]) {
+        [[NSNotificationCenter defaultCenter] addObserver:self
+                                                 selector:@selector(handleStartCallNotification:)
+                                                     name:RNCallKitHandleStartCallNotification
+                                                   object:nil];
+        _isStartCallActionEventListenerAdded = NO;
+    }
+    return self;
 }
 
-// Override method of RCTEventEmitter
-- (void)stopObserving
+- (void)dealloc
 {
 #ifdef DEBUG
-    NSLog(@"[RNCallKit][stopObserving]");
+    NSLog(@"[RNCallKit][dealloc]");
 #endif
     [[NSNotificationCenter defaultCenter] removeObserver:self];
 }
@@ -149,6 +155,11 @@ - (void)stopObserving
     [self requestTransaction:transaction];
 }
 
+RCT_EXPORT_METHOD(_startCallActionEventListenerAdded)
+{
+    _isStartCallActionEventListenerAdded = YES;
+}
+
 - (void)requestTransaction:(CXTransaction *)transaction
 {
 #ifdef DEBUG
@@ -272,7 +283,7 @@ + (BOOL)application:(UIApplication *)application
 #ifdef DEBUG
     NSLog(@"[RNCallKit][application:continueUserActivity]");
 #endif
-    INInteraction  *interaction = userActivity.interaction;
+    INInteraction *interaction = userActivity.interaction;
     INPerson *contact;
     NSString *handle;
 
@@ -290,9 +301,11 @@ + (BOOL)application:(UIApplication *)application
             @"handle": handle,
             @"video": @NO
         };
+
         [[NSNotificationCenter defaultCenter] postNotificationName:RNCallKitHandleStartCallNotification
                                                             object:self
                                                           userInfo:userInfo];
+
         return YES;
     }
     return NO;
@@ -303,7 +316,17 @@ - (void)handleStartCallNotification:(NSNotification *)notification
 #ifdef DEBUG
     NSLog(@"[RNCallKit][handleStartCallNotification] userInfo = %@", notification.userInfo);
 #endif
-    [self sendEventWithName:RNCallKitDidReceiveStartCallAction body:notification.userInfo];
+    int delayInSeconds;
+    if (!_isStartCallActionEventListenerAdded) {
+        // Workaround for when app is just launched and JS side hasn't registered to the event properly
+        delayInSeconds = DelayInSeconds;
+    } else {
+        delayInSeconds = 0;
+    }
+    dispatch_time_t popTime = dispatch_time(DISPATCH_TIME_NOW, (int64_t)(delayInSeconds * NSEC_PER_SEC));
+    dispatch_after(popTime, dispatch_get_main_queue(), ^{
+        [self sendEventWithName:RNCallKitDidReceiveStartCallAction body:notification.userInfo];
+    });
 }
 
 #pragma mark - CXProviderDelegate