Skip to content

Multiple fixes on Android #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Conversation

saif-o99
Copy link

@saif-o99 saif-o99 commented Aug 15, 2023

This PR deliver some fixes & new code

1- checkIsInManagedCall was added to check if there is a native active call in android, in my case this was useful to check if there is a native active call, prevent app from making a call

2- onHasActiveCall was added to tell the JS side about native call status, in my case this covered the case where you are in an app call then you accept a native call, this will trigger this event which i end the call by it. so no two calls be on the same time. before, the two calls were running at the same time

3- change in VoiceConnectionService.java is to fix #625

4- onHostDestroy has been added to stop all calls and processes when app is killed

@saif-o99
Copy link
Author

@manuquentin Can you please check this? Thanks

@manuquentin
Copy link
Contributor

Thanks @saif-o99 , can you please add documentation about the new event ?

@saif-o99
Copy link
Author

@manuquentin Done

@saif-o99 saif-o99 requested a review from wilmxre August 16, 2023 07:52
@saif-o99 saif-o99 requested a review from manuquentin August 16, 2023 07:59
@saif-o99
Copy link
Author

hey @manuquentin , is this gonna be merged soon?

@manuquentin manuquentin merged commit 97f9a6a into react-native-webrtc:master Aug 17, 2023
ramijarrar added a commit to avorra/react-native-callkeep that referenced this pull request Oct 31, 2023
The use of TelephonyCallback was introduced in react-native-webrtc#724.

This is only supported on Android SDK v31+.
ramijarrar added a commit to avorra/react-native-callkeep that referenced this pull request Oct 31, 2023
The use of TelephonyCallback was introduced in react-native-webrtc#724.

This is only supported on Android SDK v31+.
@dkornilove
Copy link

@saif-o99, @manuquentin, the new onHostDestroy behavior should be optional. I spent two days debugging after updating my app dependencies because the foreground service and current call started to disappear when the app is swiped away from recents. So this was unexpected breaking feature for me

@saif-o99
Copy link
Author

@saif-o99, @manuquentin, the new onHostDestroy behavior should be optional. I spent two days debugging after updating my app dependencies because the foreground service and current call started to disappear when the app is swiped away from recents. So this was unexpected breaking feature for me

Sorry to hear that, but the default behaviour of any app is that when you kill the app you kill everything related to it.
try kill for instance Facebook Messenger while in a call. the call will be closed. so having call active while you don't have the app in the background is confusing for the users and seems like a bug.

@dkornilove
Copy link

@saif-o99 Speaking for myself, this behavior is unexpected and likely affects others as well. Throughout the library's existence, the behavior has been consistent, and its sudden change without announcement is surprising. I utilize foreground services not only for calls, so it's critical for me that the activity isn't completely killed after closing the app. The foreground service is designed to continue functioning even when the app is closed. Why does a library responsible only for calls override the behavior of the entire application?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CallUUID changes after startCall
4 participants