-
Notifications
You must be signed in to change notification settings - Fork 461
Multiple fixes on Android #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@manuquentin Can you please check this? Thanks |
Thanks @saif-o99 , can you please add documentation about the new event ? |
@manuquentin Done |
hey @manuquentin , is this gonna be merged soon? |
The use of TelephonyCallback was introduced in react-native-webrtc#724. This is only supported on Android SDK v31+.
The use of TelephonyCallback was introduced in react-native-webrtc#724. This is only supported on Android SDK v31+.
@saif-o99, @manuquentin, the new |
Sorry to hear that, but the default behaviour of any app is that when you kill the app you kill everything related to it. |
@saif-o99 Speaking for myself, this behavior is unexpected and likely affects others as well. Throughout the library's existence, the behavior has been consistent, and its sudden change without announcement is surprising. I utilize foreground services not only for calls, so it's critical for me that the activity isn't completely killed after closing the app. The foreground service is designed to continue functioning even when the app is closed. Why does a library responsible only for calls override the behavior of the entire application? |
This PR deliver some fixes & new code
1-
checkIsInManagedCall
was added to check if there is a native active call in android, in my case this was useful to check if there is a native active call, prevent app from making a call2-
onHasActiveCall
was added to tell the JS side about native call status, in my case this covered the case where you are in an app call then you accept a native call, this will trigger this event which i end the call by it. so no two calls be on the same time. before, the two calls were running at the same time3- change in VoiceConnectionService.java is to fix #625
4-
onHostDestroy
has been added to stop all calls and processes when app is killed