Skip to content

Commit c6f1c54

Browse files
authored
refactor:去除冗余代码 (#24)
Signed-off-by: wupingyuan <wupingyuan2@h-partners.com>
1 parent f78f753 commit c6f1c54

File tree

4 files changed

+3
-21
lines changed

4 files changed

+3
-21
lines changed

harmony/spring_scrollview/src/main/cpp/SpringScrollViewArkTsMessageHandler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
* SOFTWARE.
2323
*/
2424

25-
#include "SpringScrollViewArkTSMessageHandler.h"
25+
#include "SpringScrollViewArkTsMessageHandler.h"
2626
#include "SpringScrollViewNode.h"
2727
#include <EventBus/EventHandler.h>
2828
#include "EventBus/EventBus.h"

harmony/spring_scrollview/src/main/cpp/SpringScrollViewComponentInstance.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ void SpringScrollViewComponentInstance::onPropsChanged(SharedConcreteProps const
5757
DLOG(INFO) << "SpringScrollViewComponentInstance::setProps refreshHeaderHeight: " << p->refreshHeaderHeight
5858
<< " loadingFooterHeight " << p->loadingFooterHeight << " bounces " << p->bounces << " allLoaded " << p->allLoaded
5959
<< " inverted " << p->inverted << " scrollEnabled " << p->scrollEnabled << " directionalLockEnabled " << p->directionalLockEnabled
60-
<< " initialContentOffset.x " << p->initialContentOffset.x << " initialContentOffset.y " << " pagingEnabled " << p->pagingEnabled
60+
<< " initialContentOffset.x " << p->initialContentOffset.x << " initialContentOffset.y " << initialContentOffset.y << " pagingEnabled " << p->pagingEnabled
6161
<< " pageSize.width " << p->pageSize.width << " pageSize.height " << p->pageSize.height << " decelerationRate " << p->decelerationRate;
6262
refreshHeaderHeight = p->refreshHeaderHeight;
6363
loadingFooterHeight = p->loadingFooterHeight;

harmony/spring_scrollview/src/main/cpp/SpringScrollViewPackage.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
#include "SpringScrollViewJSIBinder.h"
3131
#include "SpringScrollViewNapiBinder.h"
3232
#include "SpringScrollViewComponentInstance.h"
33-
#include "SpringScrollViewEmitRequestHandler.h"
3433
#include "SpringScrollViewTurboModule.h"
3534
#include "SpringScrollViewArkTsMessageHandler.h"
3635

@@ -81,11 +80,7 @@ class SpringScrollViewPackage : public Package {
8180
{"SpringScrollView", std::make_shared<SpringScrollViewNapiBinder>()},
8281
};
8382
}
84-
85-
EventEmitRequestHandlers createEventEmitRequestHandlers() override {
86-
return {std::make_shared<SpringScrollViewEmitRequestHandler>()};
87-
}
88-
83+
8984
std::unique_ptr<TurboModuleFactoryDelegate> createTurboModuleFactoryDelegate() override {
9085
return std::make_unique<SpringScrollViewContextFactoryDelegate>();
9186
}

harmony/spring_scrollview/src/main/cpp/SpringScrollViewTurboModule.cpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,5 @@ namespace rnoh {
2828
SpringScrollViewTurboModule::SpringScrollViewTurboModule(const ArkTSTurboModule::Context ctx,
2929
const std::string name)
3030
: ArkTSTurboModule(ctx, name) {
31-
methodMap_ = {
32-
ARK_METHOD_METADATA(startInnerAnimation, 3),
33-
ARK_METHOD_METADATA(startOuterAnimation, 3),
34-
ARK_METHOD_METADATA(startOuterHorizontalAnimation, 3),
35-
ARK_METHOD_METADATA(startInnerHorizontalAnimation, 3),
36-
ARK_METHOD_METADATA(startReboundAnimation, 3),
37-
ARK_METHOD_METADATA(startHorizontalReboundAnimation, 3),
38-
ARK_METHOD_METADATA(startEndRefresh, 3),
39-
ARK_METHOD_METADATA(startEndLoading, 3),
40-
ARK_METHOD_METADATA(startScrollX, 3),
41-
ARK_METHOD_METADATA(startScrollY, 3),
42-
ARK_METHOD_METADATA(cancelAnimation, 0),
43-
};
4431
}
4532
} // namespace rnoh

0 commit comments

Comments
 (0)