Fix initial event emission on iOS and tracing in example app (oblador#91)

Author: oblador

examples/vanilla/App.tsx

@@ -33,7 +33,7 @@ const traceRender: ProfilerOnRenderCallback = (
   interactions // the Set of interactions belonging to this update
 ) =>
   performance.measure(id, {
-    start: performance.timeOrigin + startTime,
+    start: startTime,
     duration: actualDuration,
   });
 

examples/vanilla/ios/Example/AppDelegate.mm

@@ -31,7 +31,6 @@ @implementation AppDelegate
 
 - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
 {
-  [RNPerformance.sharedInstance mark:@"appDelegateStart" ephemeral:NO];
   RCTAppSetupPrepareApp(application);
 
   RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
@@ -58,9 +57,8 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
   self.window.rootViewController = rootViewController;
   [self.window makeKeyAndVisible];
   dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(1.0 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
-    [RNPerformance.sharedInstance metric:@"slowCustomMetric" value:@(420.69) detail:@{ @"unit": @"$DOGE" }];
+    [RNPerformance.sharedInstance metric:@"slowCustomMetric" value:@(420.69) detail:@{ @"unit": @"$DOGE" } ephemeral:NO];
   });
-  [RNPerformance.sharedInstance mark:@"appDelegateEnd" ephemeral:NO];
   return YES;
 }
 

packages/react-native-performance/ios/RNPerformanceManager.mm

@@ -47,18 +47,22 @@ - (void)setBridge:(RCTBridge *)bridge
     [super setBridge:bridge];
     [RNPerformance.sharedInstance clearEphemeralEntries];
     [[NSNotificationCenter defaultCenter] addObserver:self
-                                             selector:@selector(contentDidAppear)
+                                             selector:@selector(emitIfReady)
                                                  name:RCTContentDidAppearNotification
                                                object:nil];
+    [[NSNotificationCenter defaultCenter] addObserver:self
+                                             selector:@selector(emitIfReady)
+                                                 name:RCTJavaScriptDidLoadNotification
+                                               object:nil];
     [[NSNotificationCenter defaultCenter] addObserver:self
                                              selector:@selector(customEntryWasAdded:)
                                                  name:RNPerformanceEntryWasAddedNotification
                                                object:nil];
 }
 
-- (void)contentDidAppear
+- (void)emitIfReady
 {
-    if(didEmit != YES) {
+    if (!didEmit && hasListeners && [self.bridge.performanceLogger valueForTag:RCTPLTTI] != 0 && [self.bridge.performanceLogger valueForTag:RCTPLScriptExecution] != 0) {
         [self emitEntries];
     }
 }
@@ -114,7 +118,7 @@ - (void)invalidate
 - (void)startObserving
 {
     hasListeners = YES;
-    if (didEmit != YES && [self.bridge.performanceLogger valueForTag:RCTPLTTI] != 0) {
+    if (didEmit != YES && [self.bridge.performanceLogger valueForTag:RCTPLTTI] != 0 && [self.bridge.performanceLogger valueForTag:RCTPLScriptExecution] != 0) {
         [self emitEntries];
     }
 }