Skip to content

Commit a2f9014

Browse files
authored
Merge pull request #3 from Inkmusun/sig
fix: 更改TurboModule中的console为hilog
2 parents d14a08b + 8f01646 commit a2f9014

File tree

3 files changed

+45
-10
lines changed

3 files changed

+45
-10
lines changed

harmony/file_viewer.har

226 Bytes
Binary file not shown.
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
import hilog from '@ohos.hilog';
2+
3+
class Logger {
4+
private domain: number;
5+
private prefix: string;
6+
private format: string = '%{public}s, %{public}s';
7+
private isDebug: boolean;
8+
9+
constructor(prefix: string = 'TurboModule', domain: number = 0xFF00, isDebug = false) {
10+
this.prefix = prefix;
11+
this.domain = domain;
12+
this.isDebug = isDebug;
13+
}
14+
15+
debug(...args: string[]): void {
16+
if (this.isDebug) {
17+
hilog.debug(this.domain, this.prefix, this.format, args);
18+
}
19+
}
20+
21+
info(...args: string[]): void {
22+
hilog.info(this.domain, this.prefix, this.format, args);
23+
}
24+
25+
warn(...args: string[]): void {
26+
hilog.warn(this.domain, this.prefix, this.format, args);
27+
}
28+
29+
error(...args: string[]): void {
30+
hilog.error(this.domain, this.prefix, this.format, args);
31+
}
32+
}
33+
34+
export default new Logger('FileViewerTurboModule', 0xFF00, true)

harmony/file_viewer/src/main/ets/RNFileViewerTurboModule.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import wantConstant from '@ohos.app.ability.wantConstant';
88
import fs from '@ohos.file.fs';
99
import mime from 'mime';
1010
import EventEmitter from './EventMitter';
11+
import Hilog from './Logger';
1112
import type { ISubscribe } from './EventMitter';
1213

1314
type EmitID = ISubscribe['id'];
@@ -38,6 +39,7 @@ export class RNFileViewerTurboModule extends TurboModule implements TM.FileViewe
3839
(id: EmitID, error: string) => {
3940
if (id === openSubscription.id) {
4041
openSubscription.$off();
42+
this.ctx.rnInstance.emitDeviceEvent(OPEN_EVENT, { id: currentId });
4143
return error ? reject(new Error(error)) : resolve();
4244
}
4345
},
@@ -47,8 +49,8 @@ export class RNFileViewerTurboModule extends TurboModule implements TM.FileViewe
4749
DISMISS_EVENT,
4850
(id: EmitID) => {
4951
if (id === dismissSubscription.id) {
50-
this.ctx.rnInstance.emitDeviceEvent(DISMISS_EVENT, { id: currentId });
5152
dismissSubscription.$off();
53+
this.ctx.rnInstance.emitDeviceEvent(DISMISS_EVENT, { id: currentId });
5254
}
5355
},
5456
);
@@ -57,13 +59,12 @@ export class RNFileViewerTurboModule extends TurboModule implements TM.FileViewe
5759
fs.stat(filepath)
5860
.then((stat: fs.Stat) => {
5961
this.OpenFile(filepath, this.ctx, _options);
60-
console.info('get file info succeed, the size of file is ' + stat.size);
6162
resolve();
6263
})
6364
.catch((err: BusinessError) => {
64-
console.error('get file info failed with error message: ' + err.message + ', error code: ' + err.code);
65-
reject('get file info failed with error message: ' + err.message + ', error code: ' + err.code);
66-
throw err;
65+
Hilog.error('get file info failed with error message: ' + err.message + ', error code: ' + err.code);
66+
reject('get file info failed with error code: ' + err.code);
67+
throw new Error('err.code:' + err.code);
6768
});
6869
});
6970
}
@@ -113,8 +114,8 @@ export class RNFileViewerTurboModule extends TurboModule implements TM.FileViewe
113114
(err: BusinessError, result: common.AbilityResult) => {
114115
if (err.code) {
115116
// 处理业务逻辑错误
116-
console.error(`startAbilityForResult failed, code is ${err.code}, message is ${err.message}`);
117-
throw new Error(err.message);
117+
Hilog.error(`startAbilityForResult failed, code is ${err.code}`);
118+
throw new Error('err.code:' + err.code);
118119
}
119120
eventEmitter.$emit(OPEN_EVENT);
120121
// 关闭ability
@@ -124,7 +125,7 @@ export class RNFileViewerTurboModule extends TurboModule implements TM.FileViewe
124125
},
125126
);
126127
} catch (error) {
127-
console.error(`Failed to startAbility. message: ${error}`);
128+
Hilog.error(`Failed to startAbility. message: ${error}`);
128129
eventEmitter.$emit(OPEN_EVENT, error);
129130
}
130131
}
@@ -170,9 +171,9 @@ export class RNFileViewerTurboModule extends TurboModule implements TM.FileViewe
170171
eventEmitter.$emit(OPEN_EVENT);
171172
})
172173
.catch((err: BusinessError) => {
173-
console.error(`Failed to openPreview, err.code = ${err.code}, err.message = ${err.message}`);
174+
Hilog.error(`Failed to openPreview, err.code = ${err.code}`);
174175
eventEmitter.$emit(OPEN_EVENT, err);
175-
throw new Error(err.message);
176+
throw new Error('err.code:' + err.code);
176177
});
177178
}
178179

0 commit comments

Comments
 (0)