0.59.x Discussion

[grabbou]

Conversation on this thread are limited to 0.59 releases, major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59 RC cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[shawnthye]

Hi, will this facebook/react-native#23430 come into the next patch?

[grabbou]

Cherry pick facebook/react-native@e10d984 to upgrade Jest from an alpha release.

[OlivierFreyssinet-old]

Hi! Is this facebook/react-native@58c3a4c going to be in 0.59 ?

[sunnylqm]

Hi can you cherry pick this one facebook/react-native@d2153fc

[tijp]

Hello! Can facebook/react-native#23446 be cherry picked for 0.59?

[grabbou]

We decided to wait with 0.59 stable release till next week (Monday/Tuesday) till there's more context on the aforementioned regression. We want to be sure whether it's a major that should be fixed before a stable release happen or a minor that we can disclose in the changelog as a "known issue".

[kelset]

@cjroth given that, as you posted in the issue, this seems to be a long lasting issue with RN (going as far as 0.57 at least) it won’t be considered a blocker for the release on 0.59.0. OFC any help you can provide over there in terms of debugging it and PRs will be super appreciated, and we’ll see how we can prioritize it against the current roadmap & pipeline.

Also, the PR with the fix of the blocker mentioned above is being imported, so hopefully we can still release 0.59.0 next week.

[cjroth]

@kelset sweet, excited about 0.59.0, thanks for the reply. I wish I had more time and was better at the native side of things. If I can find some time I might poke around but I already spent a few days tracking it down so not sure if I'll be able to. Just wanted to make sure some folks in here were aware of it!

[grabbou]

Turned out the issue was not really major. Anyway, since the PR is already being imported (facebook/react-native#23823), we're going to wait for it to land and then, cut the RC.

I am hoping that means "today"

Update: Going to release tomorrow due to some minor issues on CircleCI caused by few of the cherry-picks.

[grabbou]

Closing this one as 0.59.0 is out. Let's continue discussions in a separate issue.