0.61.x Discussion

[grabbou]

Conversation on this thread are limited to 0.61.x issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.x cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry-pick is a complicated port, you will be asked to create the PR to the 0.61-stable branch yourself, in order to ensure that the process proceeds smoothly

[elicwhite]

I know we aren't thinking about cherry picks yet, but it would be great if we are able to get this into 0.61 facebook/react-native@b8d6ef3

[kelset]

should we just wait until master is green and re-cut after that?

[grabbou]

I haven't been able to get any updates regarding CI failures for the past few days and it's not clear when they will be fixed.

After discussing it on the #releases channel, we have decided to ship it "as is" because it works locally and it's an RC.

It's a requirement to cherry-pick CI fixes before we go stable, but we want to ship some of the new features out the door.

[grabbou]

I have managed to dig deeper and fix a few tests. I am now working on fixing use_framework! tests to make sure we ship a release that works 100%.

I will get back with the update, once fixed, we are good to go.

[fkgozali]

The following should be picked:

• facebook/react-native@947e71a
• facebook/react-native@59f84ca

It should fix some OOM issue when having a lot of images (especially GIFs)

[grabbou]

I have picked them @fkgozali. The release is now being published. I have managed to resolve CircleCI issues by contacting their support team.

[grabbou]

That said, I have also unlocked this thread now that the release is going to be available really soon.

[gaodeng]

Since iOS 13 & Android 10 will be officially released soon, I really hope that this commit facebook/react-native#26172 about Dark Mode can be merged quickly.

[brentvatne]

@gaodeng - i didn't add android support to it yet but https://github.com/expo/react-native-appearance is also something you can use right now. it's that PR extracted to a lib that works on react-native 0.59+ (and maybe earlier, at least the parts w/o hooks)

[owinter86]

Not sure if this is a bug, or the pro tip regarding the ios splash screen is no longer valid.

But if it is implemented, the splash screen is permanently rendered above the app and is never dismissed.