default tsconfig.json added Closes #70 #83
Conversation
tsconfig.json
Outdated
| "target": "es5" | ||
| }, | ||
| "exclude": [ | ||
| "amplify", |
There was a problem hiding this comment.
You can remove this white space? 😅
tsconfig.json
Outdated
| "experimentalDecorators": true, | ||
| "forceConsistentCasingInFileNames": false, | ||
| "importHelpers": true, | ||
| "lib": ["dom", "es2015", "es2016", "es2017" ], |
There was a problem hiding this comment.
Do we really need to target dom here?
tsconfig.json
Outdated
| "allowSyntheticDefaultImports": true, | ||
| "allowUnreachableCode": false, | ||
| "allowUnusedLabels": false, | ||
| "baseUrl": ".", |
There was a problem hiding this comment.
Would be better to use baseUrl: "./"? Since as described at the TS Docs, you only need to use baseUrl: . when setting paths at your TS config.
There was a problem hiding this comment.
Thanks for your contribution. I think this config is too specific. I would better like it in a form like here (actually you could just copy this file). E.g. we don't need to exclude weback or turn of some rules for everyone. https://github.com/react-native-community/react-native-template-typescript/blob/legacy/tsconfig.json
|
Thank you for the comments. I have added a more generalised tsconfig.json file |
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)