Skip to content

Allow TypeScript to resolve JSON modules #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

Allow TypeScript to resolve JSON modules #209

merged 1 commit into from
Jul 20, 2021

Conversation

sheepsteak
Copy link
Contributor

I can't find any reason why this isn't enabled already and it was added in TypeScript 2.9 so should work for everyone.

emin93
emin93 approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@emin93 emin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an issue with enabling this. Although, be aware that the tsconfig.json is only used for type checking.

@emin93 emin93 merged commit df72937 into react-native-community:master Jul 20, 2021
@sheepsteak sheepsteak deleted the patch-1 branch July 21, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emin93 emin93 emin93 approved these changes

@radko93 radko93 Awaiting requested review from radko93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheepsteak @emin93