Skip to content

Fix file mode and whitespace errors #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

friederbluemle
Copy link
Contributor

A bunch of non-executable files in the repo erroneously had the executable bit set. This fixes it by changing the file mode from 755 to 644.

It also fixes all whitespace errors in this repo - e.g. missing newline at EOF, trailing whitespace.

@emin93
Copy link
Member

emin93 commented Mar 20, 2020

The RN TypeScript template is based on the default RN template (https://github.com/facebook/react-native/tree/v0.61.5/template) and aims to be as consistent as possible with it. It seems that the issue persists there as well, so I'd suggest you to create a PR in the RN repo and then we merge it over here.

@friederbluemle
Copy link
Contributor Author

Thanks for your reply @emin93 - The main React Native template does not contain trailing whitespace errors (or incorrectly set file modes). If you think otherwise, can you please point me to the specific files you're referring to? Thank you!

@emin93
Copy link
Member

emin93 commented Mar 20, 2020

Welp, I relied too much on the GitHub editor/viewer which seems to not render EOF newlines 😅. I just downloaded the default template and realized they do indeed have EOF newlines. Therefore I apologize.

@emin93 emin93 merged commit e12d9ec into react-native-community:master Mar 20, 2020
@friederbluemle friederbluemle deleted the update-project branch March 20, 2020 19:25
@friederbluemle
Copy link
Contributor Author

Haha, no worries, thanks @emin93 👍
Have a nice weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants