Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Running... note to the init command #2305

Closed
wants to merge 2 commits into from
Closed

Conversation

cortinico
Copy link
Member

Summary:

This is an implementation part of react-native-community/discussions-and-proposals#759
I'm waiting for the RFC to be approved before we can merge this, but I'd like to get a review.

Test Plan:

@szymonrybczak do you know how I can easily test this?

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check our e2e tests under __e2e__/init.test.ts. Some will likely fail because this will be logged in the text stream written to snapshots

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
@cortinico
Copy link
Member Author

You can check our e2e tests under __e2e__/init.test.ts. Some will likely fail because this will be logged in the text stream written to snapshots

Great will wait for test failures to follow up here then

@cortinico
Copy link
Member Author

Closing in favor of facebook/react-native#43127

@cortinico cortinico closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants