Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Upgrade metro dependencies to 0.72.0 #1665

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

huntie
Copy link
Collaborator

@huntie huntie commented Jul 29, 2022

Summary:

Upgrades Metro dependencies to v0.72.0. The main user-impacting features this release includes are out-of-the-box support for .cjs and .mjs files and the new React 17 JSX transform, as well as strict CLI validation when metro is run directly.

Per the release notes we shared (linked below), I am suggesting that this is a breaking change for RN CLI.

Metro release notes: https://github.com/facebook/metro/releases/tag/v0.72.0
Changelog between 0.71.3 and 0.72.0: https://github.com/facebook/metro/compare/v0.71.3..v0.72.0

Test Plan:

  • Updated dependencies with yarn.
  • ✅ Ran yarn test.

@thymikee
Copy link
Member

Will 0.72 be a part of RN 0.70?

@huntie
Copy link
Collaborator Author

huntie commented Aug 1, 2022

Partially at present, as we've upgraded relevant dependencies in facebook/react-native#44ded6. In general, we haven't been making RN-version-dependent changes in Metro, and are shipping on an independent cadence.

The aim for RN 0.70 would be to merge this PR and update the RN CLI dependency in that repo fairly soon, which will then fully bring in this latest version of Metro.

@thymikee
Copy link
Member

thymikee commented Aug 1, 2022

Right. But before merging that, I'd like to confirm that facebook/react-native@44ded6b is going to be cherry-picked to 0.70. Otherwise we'll be mismatched, which can cause some incompatibility. cc @kelset @cortinico can you advise?

@kelset
Copy link
Member

kelset commented Aug 1, 2022

we can make sure to merge that commit for the next RC; this will require a new CLI v9 version bump but it's ok.

@cortinico
Copy link
Member

+1 for having 0.72 inside RN 0.70

@thymikee
Copy link
Member

thymikee commented Aug 1, 2022

Alright, let's do this!

@thymikee thymikee merged commit ac52302 into react-native-community:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants