fix: JDK version check wouldn't detect JDK 8 correctly - #1395
Merged
grabbou merged 1 commit intoJul 6, 2021
Merged
Conversation
`envinfo` uses `javac -version` to work out the JDK version number. The doctor command was looking for a semver range of `>= 8` but this won't work for JDK 8 as it uses the old style numbering scheme (e.g. `1.8.x` not `8.x.x`). JDKs 9+ use the new version numbering scheme. Fixes react-native-community#1255
liamjones
force-pushed
the
fix-jdk-version-check
branch
from
April 5, 2021 12:25
bb900bf to
8852345
Compare
grabbou
approved these changes
Jul 6, 2021
grabbou
left a comment
grabbou
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
envinfousesjavac -versionto work out the JDK version number. The doctor command was looking for a semver range of>= 8but this won't work for JDK 8 as it uses the old style numbering scheme (e.g.1.8.xnot8.x.x). JDKs 9+ use the new version numbering scheme.Fixes #1255
Test Plan:
On macOS, before applying this PR's changes:
brew install openjdk@8export JAVA_HOME=$(/usr/libexec/java_home -v 1.8)javac -versionoutputs something likejavac 1.8.0_282react-native doctorObserve doctor complains about the JDK version:
Apply changes and run
react-native doctoragain, observe 8 is now correctly detected as supported:Repeat the above steps with JDK 9+ to confirm they're still correctly detected.