Skip to content

Commit ca4ae35

Browse files
Caleb Meredithfacebook-github-bot
authored andcommitted
@allow-large-files Upgrade xplat/js to Flow v0.66
Reviewed By: gabelevi Differential Revision: D7016717 fbshipit-source-id: 2bd2fd67074ba5d405ecd63a1aeb37354f8634c9
1 parent daab737 commit ca4ae35

File tree

5 files changed

+1
-40
lines changed

5 files changed

+1
-40
lines changed

__tests__/fs-mock-test.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,10 @@ describe('fs mock', () => {
3030
it('stores content correctly', () => {
3131
fs.writeFileSync('/test', 'foobar', 'utf8');
3232
const content = fs.readFileSync('/test', 'utf8');
33-
/* $FlowFixMe(>=0.56.0 site=react_native_oss) This comment suppresses an
34-
* error found when Flow v0.56 was deployed. To see the error delete this
35-
* comment and run Flow. */
3633
expect(content).toEqual('foobar');
3734
});
3835

3936
it('fails on missing path', () => {
40-
/* $FlowFixMe(>=0.56.0 site=react_native_oss) This comment suppresses an
41-
* error found when Flow v0.56 was deployed. To see the error delete this
42-
* comment and run Flow. */
4337
expect(() =>
4438
fs.writeFileSync('/dir/test', 'foobar', 'utf8'),
4539
).toThrowError('ENOENT: no such file or directory');
@@ -57,9 +51,6 @@ describe('fs mock', () => {
5751
fs.mkdirSync('/dir', 0o777);
5852
fs.writeFileSync('/dir/test', 'foobar', 'utf8');
5953
const content = fs.readFileSync('/dir/test', 'utf8');
60-
/* $FlowFixMe(>=0.56.0 site=react_native_oss) This comment suppresses an
61-
* error found when Flow v0.56 was deployed. To see the error delete this
62-
* comment and run Flow. */
6354
expect(content).toEqual('foobar');
6455
});
6556

@@ -68,9 +59,6 @@ describe('fs mock', () => {
6859
fs.writeFileSync('/dir/test', 'foobar', 'utf8');
6960
fs.mkdirSync('/dir', 0o777);
7061
const content = fs.readFileSync('/dir/test', 'utf8');
71-
/* $FlowFixMe(>=0.56.0 site=react_native_oss) This comment suppresses an
72-
* error found when Flow v0.56 was deployed. To see the error delete this
73-
* comment and run Flow. */
7462
expect(content).toEqual('foobar');
7563
});
7664
});

bundle/buildBundle.js

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,24 +10,12 @@
1010
'use strict';
1111

1212
const log = require('../util/log').out('bundle');
13-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
14-
* found when Flow v0.54 was deployed. To see the error delete this comment and
15-
* run Flow. */
1613
const Server = require('metro/src/Server');
1714
const {Terminal} = require('metro-core');
18-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
19-
* found when Flow v0.54 was deployed. To see the error delete this comment and
20-
* run Flow. */
2115
const TerminalReporter = require('metro/src/lib/TerminalReporter');
22-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
23-
* found when Flow v0.54 was deployed. To see the error delete this comment and
24-
* run Flow. */
2516
const TransformCaching = require('metro/src/lib/TransformCaching');
2617

2718
const {defaults} = require('metro');
28-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
29-
* found when Flow v0.54 was deployed. To see the error delete this comment and
30-
* run Flow. */
3119
const outputBundle = require('metro/src/shared/output/bundle');
3220
const path = require('path');
3321
const saveAssets = require('./saveAssets');
@@ -40,9 +28,6 @@ import type {ConfigT} from 'metro';
4028
const defaultAssetExts = defaults.assetExts;
4129
const defaultSourceExts = defaults.sourceExts;
4230
const defaultPlatforms = defaults.platforms;
43-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
44-
* found when Flow v0.54 was deployed. To see the error delete this comment and
45-
* run Flow. */
4631
const defaultProvidesModuleNodeModules = defaults.providesModuleNodeModules;
4732

4833
async function buildBundle(

bundle/types.flow.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,4 @@
88
*/
99
'use strict';
1010

11-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
12-
* found when Flow v0.54 was deployed. To see the error delete this comment and
13-
* run Flow. */
1411
export type {OutputOptions, RequestOptions} from 'metro/src/shared/types.flow';

server/runServer.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ const copyToClipBoardMiddleware = require('./middleware/copyToClipBoardMiddlewar
2525
const defaultAssetExts = Metro.defaults.assetExts;
2626
const defaultSourceExts = Metro.defaults.sourceExts;
2727
const defaultPlatforms = Metro.defaults.platforms;
28-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
29-
* found when Flow v0.54 was deployed. To see the error delete this comment and
30-
* run Flow. */
3128
const defaultProvidesModuleNodeModules =
3229
Metro.defaults.providesModuleNodeModules;
3330
const errorhandler = require('errorhandler');
@@ -46,17 +43,11 @@ const statusPageMiddleware = require('./middleware/statusPageMiddleware.js');
4643
const systraceProfileMiddleware = require('./middleware/systraceProfileMiddleware.js');
4744
const webSocketProxy = require('./util/webSocketProxy.js');
4845

49-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
50-
* found when Flow v0.54 was deployed. To see the error delete this comment and
51-
* run Flow. */
5246
const TransformCaching = require('metro/src/lib/TransformCaching');
5347

5448
const {ASSET_REGISTRY_PATH} = require('../core/Constants');
5549

5650
import type {ConfigT} from 'metro';
57-
/* $FlowFixMe(>=0.54.0 site=react_native_oss) This comment suppresses an error
58-
* found when Flow v0.54 was deployed. To see the error delete this comment and
59-
* run Flow. */
6051
import type {Reporter} from 'metro/src/lib/reporting';
6152

6253
export type Args = {|

templates/HelloWorld/_flowconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
5151
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
5252

5353
[version]
54-
^0.65.0
54+
^0.66.0

0 commit comments

Comments
 (0)