Skip to content

Commit 6939ebe

Browse files
franticfacebook-github-bot-4
authored andcommitted
Improve react-native-xcode.sh integration
Summary: Inspired by conversation in facebook/react-native#5374, this PR improves `react-native-xcode.sh`: * No longer depends on global `react-native` binary * Gracefully handles missing `node` dependency and adds a new way to configure the path to `node` in non-standard installation environments This is how the error looks like: ![image](https://cloud.githubusercontent.com/assets/192222/12538882/3f9b5c3e-c29a-11e5-84fc-c7ccedf1c46a.png) Closes facebook/react-native#5518 Reviewed By: svcscm Differential Revision: D2861116 Pulled By: frantic fb-gh-sync-id: 9a80eda6c844d066e34369b1cda503955171485b
1 parent e41f001 commit 6939ebe

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

generator-ios/templates/xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@
525525
);
526526
runOnlyForDeploymentPostprocessing = 0;
527527
shellPath = /bin/sh;
528-
shellScript = "../node_modules/react-native/packager/react-native-xcode.sh";
528+
shellScript = "export NODE_BINARY=node\n../node_modules/react-native/packager/react-native-xcode.sh";
529529
showEnvVarsInLog = 1;
530530
};
531531
/* End PBXShellScriptBuildPhase section */

0 commit comments

Comments
 (0)