chore: upgrade Jest to 26 (#1151)

* chore: upgrade Jest to 26

* jest@26.3.0

* bump pretty-format too

* bump types to 26 as well

* chore: use latest; update snapshot

* chore: bump pretty-format as well

* yarn deduplicate

Author: thymikee

jest.config.js

@@ -1,6 +1,7 @@
 const common = {
   testEnvironment: 'node',
   snapshotSerializers: [require.resolve('jest-snapshot-serializer-raw')],
+  testRunner: 'jest-circus/runner',
 };
 
 module.exports = {

package.json

@@ -30,11 +30,11 @@
     "@babel/preset-typescript": "^7.3.3",
     "@react-native-community/eslint-config": "^2.0.0",
     "@types/glob": "^7.1.1",
-    "@types/jest": "^25.1.4",
+    "@types/jest": "^26.0.15",
     "@types/mkdirp": "^0.5.2",
     "@types/node": "^10.0.0",
     "@types/node-fetch": "^2.3.7",
-    "babel-jest": "^25.2.4",
+    "babel-jest": "^26.6.2",
     "babel-plugin-module-resolver": "^3.2.0",
     "chalk": "^3.0.0",
     "chokidar": "^3.3.1",
@@ -45,7 +45,8 @@
     "eslint-plugin-import": "^2.17.0",
     "execa": "^1.0.0",
     "glob": "^7.1.3",
-    "jest": "^25.2.4",
+    "jest": "^26.6.2",
+    "jest-circus": "^26.6.2",
     "jest-snapshot-serializer-raw": "^1.1.0",
     "lerna": "^3.18.4",
     "metro-memory-fs": "^0.63.0",

packages/cli-server-api/package.json

@@ -12,7 +12,7 @@
     "compression": "^1.7.1",
     "connect": "^3.6.5",
     "errorhandler": "^1.5.0",
-    "pretty-format": "^25.1.0",
+    "pretty-format": "^26.6.2",
     "serve-static": "^1.13.1",
     "ws": "^1.1.0"
   },

packages/cli/package.json

@@ -57,7 +57,7 @@
     "mkdirp": "^0.5.1",
     "node-stream-zip": "^1.9.1",
     "ora": "^3.4.0",
-    "pretty-format": "^25.2.0",
+    "pretty-format": "^26.6.2",
     "semver": "^6.3.0",
     "serve-static": "^1.13.1",
     "strip-ansi": "^5.2.0",

packages/cli/src/tools/config/__mocks__/resolveNodeModuleDir.ts

@@ -1,4 +1,4 @@
-const path = require('path');
+import path from 'path';
 
 export default function resolveNodeModuleDir(
   root: string,

packages/cli/src/tools/config/__tests__/__snapshots__/index-test.ts.snap

@@ -118,3 +118,7 @@ Object {
   },
 }
 `;
+
+exports[`should skip packages that have invalid configuration: dependencies config 1`] = `Object {}`;
+
+exports[`should skip packages that have invalid configuration: logged warning 1`] = `"Package react-native has been ignored because it contains invalid configuration. Reason: \\"dependency.invalidProperty\\" is not allowed"`;

packages/cli/src/tools/config/__tests__/index-test.ts

@@ -10,7 +10,7 @@ import {
 
 jest.mock('../resolveNodeModuleDir');
 
-const DIR = getTempDirectory('resolve_config_path_test');
+let DIR = getTempDirectory('config_test');
 
 const iosPath = slash(
   require.resolve('@react-native-community/cli-platform-ios'),
@@ -60,6 +60,7 @@ beforeEach(async () => {
 afterEach(async () => await cleanup(DIR));
 
 test('should have a valid structure by default', () => {
+  DIR = getTempDirectory('config_test_structure');
   writeFiles(DIR, {
     'react-native.config.js': `module.exports = {
       reactNativePath: "."
@@ -70,6 +71,7 @@ test('should have a valid structure by default', () => {
 });
 
 test('should return dependencies from package.json', () => {
+  DIR = getTempDirectory('config_test_deps');
   writeFiles(DIR, {
     ...REACT_NATIVE_MOCK,
     'node_modules/react-native-test/package.json': '{}',
@@ -87,6 +89,7 @@ test('should return dependencies from package.json', () => {
 });
 
 test('should read a config of a dependency and use it to load other settings', () => {
+  DIR = getTempDirectory('config_test_settings');
   writeFiles(DIR, {
     ...REACT_NATIVE_MOCK,
     'node_modules/react-native-test/package.json': '{}',
@@ -114,6 +117,7 @@ test('should read a config of a dependency and use it to load other settings', (
 });
 
 test('should merge project configuration with default values', () => {
+  DIR = getTempDirectory('config_test_merge');
   writeFiles(DIR, {
     ...REACT_NATIVE_MOCK,
     'node_modules/react-native-test/package.json': '{}',
@@ -151,6 +155,7 @@ test('should merge project configuration with default values', () => {
 });
 
 test('should load commands from "react-native-foo" and "react-native-bar" packages', () => {
+  DIR = getTempDirectory('config_test_packages');
   writeFiles(DIR, {
     'node_modules/react-native-foo/package.json': '{}',
     'node_modules/react-native-foo/react-native.config.js': `module.exports = {
@@ -181,9 +186,8 @@ test('should load commands from "react-native-foo" and "react-native-bar" packag
   expect(commands).toMatchSnapshot();
 });
 
-// @todo: figure out why this test is so flaky
-// eslint-disable-next-line jest/no-disabled-tests
-test.skip('should skip packages that have invalid configuration', () => {
+test('should skip packages that have invalid configuration', () => {
+  DIR = getTempDirectory('config_test_skip');
   writeFiles(DIR, {
     'node_modules/react-native/package.json': '{}',
     'node_modules/react-native/react-native.config.js': `module.exports = {
@@ -204,6 +208,7 @@ test.skip('should skip packages that have invalid configuration', () => {
 });
 
 test('does not use restricted "react-native" key to resolve config from package.json', () => {
+  DIR = getTempDirectory('config_test_restricted');
   writeFiles(DIR, {
     'node_modules/react-native-netinfo/package.json': `{
       "react-native": "src/index.js"
@@ -221,6 +226,7 @@ test('does not use restricted "react-native" key to resolve config from package.
 });
 
 test('supports dependencies from user configuration with custom root and properties', () => {
+  DIR = getTempDirectory('config_test_custom_root');
   const escapePathSeparator = (value: string) =>
     path.sep === '\\' ? value.replace(/(\/|\\)/g, '\\\\') : value;