Fix image drag preview coordinates

react-dnd · Apr 30, 2015 · 0be5806 · 0be5806
1 parent 7e653f9
commit 0be5806
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/utils/OffsetHelpers.js b/src/utils/OffsetHelpers.js
@@ -24,15 +24,17 @@ export function getEventClientOffset(e) {
 }
 
 export function getDragPreviewOffset(sourceNode, dragPreview, clientOffset, anchorPoint) {
-  const dragPreviewOffsetFromClient = getElementClientOffset(dragPreview);
+  const isImage = dragPreview instanceof Image;
+  const dragPreviewNode = isImage ? sourceNode : dragPreview;
+
+  const dragPreviewNodeOffsetFromClient = getElementClientOffset(dragPreviewNode);
   const offsetFromDragPreview = {
-    x: clientOffset.x - dragPreviewOffsetFromClient.x,
-    y: clientOffset.y - dragPreviewOffsetFromClient.y
+    x: clientOffset.x - dragPreviewNodeOffsetFromClient.x,
+    y: clientOffset.y - dragPreviewNodeOffsetFromClient.y
   };
 
   const { offsetWidth: sourceWidth, offsetHeight: sourceHeight } = sourceNode;
   const { anchorX, anchorY } = anchorPoint;
-  const isImage = dragPreview instanceof Image;
 
   let dragPreviewWidth = isImage ? dragPreview.width : sourceWidth;
   let dragPreviewHeight = isImage ? dragPreview.height : sourceHeight;