Skip to content

Commit 2a4f330

Browse files
committed
fix test
1 parent b7388d4 commit 2a4f330

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

src/Tooltip.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,9 @@ const Tooltip = React.forwardRef<TooltipRef, TooltipProps>((props, ref) => {
135135
}
136136

137137
if (isControlled) {
138-
setPopupMounted(mergedVisible);
138+
updatePopupMounted(mergedVisible);
139139
}
140-
}, [forceRender, isControlled, mergedVisible]);
140+
}, [forceRender, isControlled, mergedVisible, updatePopupMounted]);
141141

142142
// ========================= Arrow ==========================
143143
// Process arrow configuration

tests/index.test.tsx

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -552,6 +552,25 @@ describe('rc-tooltip', () => {
552552
expect(container.querySelector('button')).toHaveAttribute('aria-describedby');
553553
});
554554

555+
it('should keep aria-describedby when controlled hidden without destroy', () => {
556+
const overlay = 'tooltip content';
557+
const { container, rerender } = render(
558+
<Tooltip overlay={overlay} visible>
559+
<button>Click me</button>
560+
</Tooltip>,
561+
);
562+
563+
expect(container.querySelector('button')).toHaveAttribute('aria-describedby');
564+
565+
rerender(
566+
<Tooltip overlay={overlay} visible={false}>
567+
<button>Click me</button>
568+
</Tooltip>,
569+
);
570+
571+
expect(container.querySelector('button')).toHaveAttribute('aria-describedby');
572+
});
573+
555574
it('should remove aria-describedby when popup is destroyed on hide', async () => {
556575
const { container } = render(
557576
<Tooltip destroyOnHidden trigger={['click']} overlay="tooltip content">

0 commit comments

Comments
 (0)