-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented rtl layout support #230
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/react-component/tabs/7crz21fiq |
Still failed. You can view coverage link to see the coverage diff: https://coveralls.io/builds/26294799 |
examples/rtl.js
Outdated
<InkTabBar | ||
onTabClick={this.onTabClick} | ||
tabBarGutter={30} | ||
direction="rtl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use context to get the direction
instead of both Tabs and InkTabBar should have direction
props?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 182 to 191 in 9dcbe12
const tabBar = React.cloneElement(this.tabBar, { | |
prefixCls, | |
navWrapper, | |
key: 'tabBar', | |
onKeyDown: this.onNavKeyDown, | |
tabBarPosition, | |
onTabClick: this.onTabClick, | |
panels: props.children, | |
activeKey: this.state.activeKey, | |
}); |
I found that i can pass direction
to all kind of tab-bars in this part of code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added.
Line 191 in ca6d50f
direction: this.props.direction, |
@zombieJ all done |
LGTM |
|
Hi there.
I've added rtl layout support to this component.
changes the tab direction with direction='rtl' property