refactor: Use channel to optimize render #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
li-jia-nan
reviewed
Mar 22, 2023
| raf(callback); | ||
| } else { | ||
| const channel = new MessageChannel(); | ||
| channel.port1.onmessage = () => callback(); |
There was a problem hiding this comment.
Suggested change
| channel.port1.onmessage = () => callback(); | |
| channel.port1.onmessage = callback; |
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 99.50% 98.07% -1.44%
==========================================
Files 4 5 +1
Lines 203 208 +5
Branches 69 68 -1
==========================================
+ Hits 202 204 +2
- Misses 1 4 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用 MessageChannel 使其批量更新在下一帧前，Resize 事件后。从而避免渲染时额外的跳动。需要多看看是否对使用有影响。
ref ant-design/ant-design#41374