feat: Change duration to number|false type

Author: wanpan11

README.md

@@ -97,7 +97,7 @@ props details:
     <thead>
     <tr>
         <th style="width: 100px;">name</th>
-        <th style="width: 50px;">type</th>
+        <th style="width: 200px;">type</th>
         <th style="width: 50px;">default</th>
         <th>description</th>
     </tr>
@@ -129,8 +129,8 @@ props details:
         </tr>
         <tr>
           <td>duration</td>
-          <td>number</td>
-          <td>1.5</td>
+          <td>number | false</td>
+          <td>4.5</td>
           <td>after duration of time, this notice will disappear.(seconds)</td>
         </tr>
         <tr>

src/Notice.tsx

@@ -38,7 +38,7 @@ const Notify = React.forwardRef<HTMLDivElement, NoticeProps & { times?: number }
   const [percent, setPercent] = React.useState(0);
   const [spentTime, setSpentTime] = React.useState(0);
   const mergedHovering = forcedHovering || hovering;
-  const mergedShowProgress = duration > 0 && showProgress;
+  const mergedShowProgress = duration && showProgress;
 
   // ======================== Close =========================
   const onInternalClose = () => {
@@ -53,7 +53,7 @@ const Notify = React.forwardRef<HTMLDivElement, NoticeProps & { times?: number }
 
   // ======================== Effect ========================
   React.useEffect(() => {
-    if (!mergedHovering && duration > 0) {
+    if (!mergedHovering && duration) {
       const start = Date.now() - spentTime;
       const timeout = setTimeout(
         () => {

src/hooks/useNotification.tsx

@@ -19,7 +19,7 @@ export interface NotificationConfig {
     | boolean
     | ({ closeIcon?: React.ReactNode; onClose?: VoidFunction } & React.AriaAttributes);
   maxCount?: number;
-  duration?: number;
+  duration?: number | false;
   showProgress?: boolean;
   pauseOnHover?: boolean;
   /** @private. Config for notification holder style. Safe to remove if refactor */

src/interface.ts

@@ -6,7 +6,7 @@ type NoticeSemanticProps = 'wrapper';
 
 export interface NoticeConfig {
   content?: React.ReactNode;
-  duration?: number | null;
+  duration?: number | false;
   showProgress?: boolean;
   pauseOnHover?: boolean;
 
@@ -32,7 +32,7 @@ export interface OpenConfig extends NoticeConfig {
   key: React.Key;
   placement?: Placement;
   content?: React.ReactNode;
-  duration?: number | null;
+  duration?: number | false;
 }
 
 export type InnerOpenConfig = OpenConfig & { times?: number };

tests/index.test.tsx

@@ -162,7 +162,7 @@ describe('Notification.Basic', () => {
           </p>
         ),
         key,
-        duration: null,
+        duration: false,
       });
     });
 
@@ -192,7 +192,7 @@ describe('Notification.Basic', () => {
             {notUpdatableValue}
           </p>
         ),
-        duration: null,
+        duration: false,
       });
     });
 
@@ -204,7 +204,7 @@ describe('Notification.Basic', () => {
           </p>
         ),
         key,
-        duration: null,
+        duration: false,
       });
     });
 
@@ -490,7 +490,7 @@ describe('Notification.Basic', () => {
           </p>
         ),
         key,
-        duration: null,
+        duration: false,
         onClick: () => {
           clicked += 1;
         },

tests/stack.test.tsx

@@ -17,7 +17,7 @@ describe('stack', () => {
             onClick={() => {
               api.open({
                 content: <div className="context-content">Test</div>,
-                duration: null,
+                duration: false,
               });
             }}
           />
@@ -56,7 +56,7 @@ describe('stack', () => {
             onClick={() => {
               api.open({
                 content: <div className="context-content">Test</div>,
-                duration: null,
+                duration: false,
                 closable: true,
               });
             }}